fix: stop polling when sdkKey is invalid #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phaym
changed the title
phaym
changed the title
Copilot finished reviewing on behalf of
phaym
November 19, 2025 16:22
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes error handling in the config manager for local bucketing to properly stop polling when an invalid SDK key is provided (401/403 errors). The fix updates exception handling to catch the correct exception types that are actually thrown by the ConfigAPIClient.
- Replaces
CloudClientError/CloudClientUnauthorizedErrorwith their parent classesAPIClientError/APIClientUnauthorizedError - Updates the unauthorized error message to be more descriptive
- Ensures polling stops when authentication fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JamieSinn
approved these changes
Nov 19, 2025
kaushalkapasi
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle config fetching errors for local bucketing: when sdkKey is incorrect and 401 or 403 received, polling should stop.
Previously these specific errors were not handled since they were not thrown from
config_client.pyonget_config()