fix: pin MEL.Abstractions and System.Text.Json to 10.0.0 in dotnet proxy#600
Open
jonathannorris wants to merge 1 commit into
Open
fix: pin MEL.Abstractions and System.Text.Json to 10.0.0 in dotnet proxy#600jonathannorris wants to merge 1 commit into
jonathannorris wants to merge 1 commit into
Conversation
DevCycle .NET SDK now requires Microsoft.Extensions.Logging.Abstractions >= 10.0.0 (via OpenFeature 2.13.0) and System.Text.Json >= 10.0.0. Both packages ship net8.0 TFMs so the proxy stays on net8.0 and the Docker base image stays on dotnet/sdk:8.0. Without explicit pins here NuGet raises NU1605 during restore.
There was a problem hiding this comment.
Pull request overview
Pins two NuGet dependencies in the .NET proxy project to resolve restore-time version conflicts (NU1605) introduced by newer transitive requirements from the DevCycle .NET SDK / OpenFeature, while keeping the proxy on net8.0 and compatible with the dotnet/sdk:8.0 Docker image.
Changes:
- Add an explicit
Microsoft.Extensions.Logging.Abstractionspackage reference at10.0.0. - Add an explicit
System.Text.Jsonpackage reference at10.0.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DevCycle .NET SDK now requires
Microsoft.Extensions.Logging.Abstractions >= 10.0.0(via OpenFeature 2.13.0) andSystem.Text.Json >= 10.0.0. Both packages shipnet8.0TFMs so the proxy can stay onnet8.0and the Docker base image stays ondotnet/sdk:8.0.Without explicit pins here, NuGet raises
NU1605during restore because the .NET 8 framework's implicit MEL reference conflicts with the transitive >= 10.0.0 requirement coming from the SDK.Related
DevCycleHQ/dotnet-server-sdk#203