Add get-changed-files action#23
Merged
IlyaKhD merged 6 commits intoDevExpress:mainfrom Sep 26, 2024
Merged
Conversation
f6489dc to
8fd36d8
Compare
pomahtri
approved these changes
Sep 24, 2024
alexslavr
reviewed
Sep 25, 2024
alexslavr
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Practical Value
Removes duplication in actions and makes internal logic for getting changed files more reliable
Before
gitcommands by determininhheadandbasecommits. This way has its pitfall - all changes from the commits that are in the master branch but not in the PR branch (when it lags behind the master branch) are considered as changed files, which is wrongAfter