Skip to content

Add get-changed-files action#23

Merged
IlyaKhD merged 6 commits intoDevExpress:mainfrom
IlyaKhD:khd/add-changed-files-action
Sep 26, 2024
Merged

Add get-changed-files action#23
IlyaKhD merged 6 commits intoDevExpress:mainfrom
IlyaKhD:khd/add-changed-files-action

Conversation

@IlyaKhD
Copy link
Copy Markdown
Contributor

@IlyaKhD IlyaKhD commented Sep 16, 2024

Practical Value

Removes duplication in actions and makes internal logic for getting changed files more reliable

Before

  • 2 implementations for same purpose of getting changed files (the 2nd one is in the monorepo: get-changed-files/action.yml)
  • the implementation that is used in this repo is based on operating with git commands by determininh head and base commits. This way has its pitfall - all changes from the commits that are in the master branch but not in the PR branch (when it lags behind the master branch) are considered as changed files, which is wrong

After

  • 1 implementation is used in all actions (the one from the monorepo will be removed)
  • thisi mplementation is based on GH API and is much more reliable

@IlyaKhD IlyaKhD self-assigned this Sep 16, 2024
@IlyaKhD IlyaKhD changed the title Add changed files action Add get-changed-files action Sep 16, 2024
@IlyaKhD IlyaKhD force-pushed the khd/add-changed-files-action branch from f6489dc to 8fd36d8 Compare September 23, 2024 13:44
Comment thread get-changed-files/action.yml Outdated
@IlyaKhD IlyaKhD merged commit d5d5b24 into DevExpress:main Sep 26, 2024
@IlyaKhD IlyaKhD deleted the khd/add-changed-files-action branch October 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants