Skip to content

fix(install-internal-package): retarget replacement to node_modules/.pnpm#38

Open
IlyaKhD wants to merge 5 commits intoDevExpress:mainfrom
IlyaKhD:khd/install-internal-package
Open

fix(install-internal-package): retarget replacement to node_modules/.pnpm#38
IlyaKhD wants to merge 5 commits intoDevExpress:mainfrom
IlyaKhD:khd/install-internal-package

Conversation

@IlyaKhD
Copy link
Copy Markdown
Contributor

@IlyaKhD IlyaKhD commented Apr 16, 2026

@IlyaKhD IlyaKhD self-assigned this Apr 16, 2026
Copilot AI review requested due to automatic review settings April 16, 2026 15:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the install-internal-package GitHub Action’s package replacement logic to work correctly with pnpm’s symlinked node_modules layout by replacing the resolved target directory rather than the symlink itself.

Changes:

  • Replace package contents at the symlink target (pnpm) instead of deleting/recreating the symlink.
  • Retarget tar extraction to the resolved package directory (realpathSync) when the entry is a symlink.
  • Ignore .DS_Store files in the repository.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
install-internal-package/replace-package.js Adjusts replacement to operate on pnpm symlink targets instead of node_modules/<pkg> directly.
.gitignore Adds .DS_Store to ignored files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread install-internal-package/replace-package.js Outdated
Comment thread install-internal-package/replace-package.js Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 16, 2026 16:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the internal package replacement script to work correctly with pnpm’s symlink-based node_modules layout by replacing the real package directory under node_modules/.pnpm rather than overwriting the top-level symlink.

Changes:

  • Preserve pnpm symlinks by resolving entryPath to its real path and replacing the symlink target contents.
  • Update extraction and directory creation to operate on the resolved target path.
  • Ignore .DS_Store in the repository.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
install-internal-package/replace-package.js Retargets replacement from the resolved package entry to the symlink target to keep pnpm resolution intact.
.gitignore Adds .DS_Store to ignored files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IlyaKhD IlyaKhD requested a review from alexslavr April 16, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants