correct server processing the form element with target=iframe#2290
Merged
miherlosev merged 3 commits intoDevExpress:masterfrom Apr 14, 2020
Merged
correct server processing the form element with target=iframe#2290miherlosev merged 3 commits intoDevExpress:masterfrom
form element with target=iframe#2290miherlosev merged 3 commits intoDevExpress:masterfrom
Conversation
AlexKamaev
changed the title
form element with target=iframeform element with target=iframe
Contributor
Author
|
@testcafe-build-bot retest |
LavrovArtem
suggested changes
Apr 13, 2020
Contributor
LavrovArtem
left a comment
LavrovArtem
left a comment
There was a problem hiding this comment.
minor code style issues
| abstract sameOriginCheck (destUrl: string, resourceUrl: string): boolean; | ||
| abstract getClassName (el: HTMLElement | ASTNode): string; | ||
| abstract isExistingTarget (target: string): boolean; | ||
| abstract isExistingTarget (target: string, el: ASTNode | void): boolean; |
Contributor
There was a problem hiding this comment.
- el: ASTNode | void
+ el?: ASTNode| while (el.parentNode) | ||
| el = el.parentNode; | ||
|
|
||
| return parse5Utils.findElement(el, e => { |
Contributor
There was a problem hiding this comment.
return parse5Utils.findElement(el, e => this.getAttr(e, 'name') === target);| return elements; | ||
| } | ||
|
|
||
| export function findElement (el: ASTNode, predicate: Function) { |
Contributor
There was a problem hiding this comment.
export function findElement (el: ASTNode, predicate: (el: ASTNode) => boolean) {| if (!el.childNodes) | ||
| return null; | ||
|
|
||
| for (let i = 0; i < el.childNodes.length; i++) { |
Contributor
There was a problem hiding this comment.
for (let child of el.childNodes)
Contributor
Author
|
FPR |
AlexKamaev
changed the title
form element with target=iframeform element with target=iframe
LavrovArtem
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The situation:
form.submitThe cause that iframe window is reloaded after form submit, because of incomplete hh server processing.
I checked two original cases and they work as expected