Add support for 'clientScripts' (close #1739) by benmonro · Pull Request #3880 · DevExpress/testcafe

benmonro · 2019-06-10T00:33:53Z

This PR will add a new section to the config file: "clientScripts"

example:

 {
    "src": "test.js",
    "browsers": [
        "chrome",
    ],
    "clientScripts": [
        "./node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js"
    ]
}

adding this to your config will cause testcafe to inject the above scripts into the browser as a script tag.

This will be very useful for testcafe-testing-library which needs to inject DomTestingLibrary into the dom, on each page-load, and will thus now only need to be configured once, and will then work on each page.

resolves #1739

testcafe-build-bot · 2019-06-10T00:40:19Z

❌ Tests for the commit d383b82 have failed. See details:

testcafe-build-bot · 2019-06-10T03:07:58Z

❌ Tests for the commit a3e17d8 have failed. See details:

testcafe-build-bot · 2019-06-10T04:16:50Z

❌ Tests for the commit 8ee520a have failed. See details:

miherlosev · 2019-06-13T13:52:56Z

Hi @benmonro

Thank you for your interest in TestCafe.
After discussing it with the team, I wrote the final API for this feature: #1739 (comment). The feature requires writing a large amount of code. It's not easy. However, you can implement this feature step by step.
As the first step, I suggest you implement the described above API only for the configuration file.

benmonro · 2019-06-13T15:19:57Z

sounds good, I actually like that proposed api better @miherlosev

Just started a new job at Walmart Labs, so not sure how much time i'll be able to spend on it, so feel free to take this PR and modify it to fit that API or do whatever you like with it. You know I ❤️ you guys! keep up the great work, i sing your praise every day!

-Ben

testcafe-build-bot · 2019-06-17T01:34:27Z

❌ Tests for the commit c2f873b have failed. See details:

testcafe-build-bot · 2019-06-24T14:28:52Z

❌ Tests for the commit 528c762 have failed. See details:

testcafe-build-bot · 2019-06-25T09:44:27Z

❌ Tests for the commit d8bb2ae have failed. See details:

testcafe-build-bot · 2019-06-25T11:11:01Z

❌ Tests for the commit 5c13989 have failed. See details:

testcafe-build-bot · 2019-06-26T09:51:04Z

❌ Tests for the commit 9b22918 have failed. See details:

testcafe-build-bot · 2019-06-26T15:41:51Z

❌ Tests for the commit 87c5e8d have failed. See details:

testcafe-build-bot · 2019-06-27T10:36:05Z

❌ Tests for the commit 37d3fc1 have failed. See details:

testcafe-build-bot · 2019-06-27T12:12:03Z

❌ Tests for the commit bbc790f have failed. See details:

testcafe-build-bot · 2019-06-28T08:49:43Z

❌ Tests for the commit 182a4fe have failed. See details:

testcafe-build-bot · 2019-06-28T09:53:54Z

❌ Tests for the commit 525f698 have failed. See details:

testcafe-build-bot · 2019-06-28T14:47:54Z

❌ Tests for the commit 115d59c have failed. See details:

testcafe-build-bot · 2019-07-01T13:49:34Z

❌ Tests for the commit a55b22d have failed. See details:

testcafe-build-bot · 2019-07-01T14:16:51Z

❌ Tests for the commit bd0498e have failed. See details:

testcafe-build-bot · 2019-07-02T10:28:21Z

❌ Tests for the commit 4c3e39b have failed. See details:

testcafe-build-bot · 2019-07-02T11:26:16Z

❌ Tests for the commit ce17adc have failed. See details:

testcafe-build-bot · 2019-07-02T12:11:12Z

❌ Tests for the commit 23f8ad5 have failed. See details:

testcafe-build-bot · 2019-07-02T15:54:22Z

❌ Tests for the commit 4052d7f have failed. See details:

testcafe-build-bot · 2019-07-03T12:19:38Z

❌ Tests for the commit ea0a195 have failed. See details:

testcafe-build-bot · 2019-07-22T16:13:45Z

❌ Tests for the commit d968d99 have failed. See details:

miherlosev · 2019-07-23T08:07:25Z

@testcafe-build-bot retest

testcafe-build-bot · 2019-07-23T08:39:13Z

❌ Tests for the commit d968d99 have failed. See details:

testcafe-build-bot · 2019-07-23T12:55:06Z

❌ Tests for the commit 99e3c7a have failed. See details:

testcafe-build-bot · 2019-07-23T15:45:32Z

❌ Tests for the commit c94a2ed have failed. See details:

miherlosev · 2019-07-24T08:05:10Z

@testcafe-build-bot retest

testcafe-build-bot · 2019-07-24T08:33:29Z

✅ Tests for the commit c94a2ed have passed. See details:

… scripts

testcafe-build-bot · 2019-07-24T12:30:07Z

✅ Tests for the commit 3226191 have passed. See details:

) * initial * fix wrong rebase * new logic for resolving relative paths (test api and others) * refactoring * fix tests * provide error messages for uncaught errors occured in injected client scripts * fix tests * fix error messages * fix server tests * fix relative paths * fix type definition * prevent multiple method calls for clientScripts and requestHooks * fix an error message during module loading * specify execution order for clientScripts and requestHooks * skip test * skip test * refix the test * fix client scripts loading order and handle module path resolving errors

benmonro mentioned this pull request Jun 10, 2019

Add the capability to execute a custom script before page initialization scripts #1739

Closed

benmonro changed the title ~~[Work in progress] add support for 'additionalScripts' in configuration.~~ add support for 'clientScripts' in configuration. Jun 17, 2019

miherlosev force-pushed the feature/additional-scripts branch from 5cd7d19 to 37d3fc1 Compare June 27, 2019 08:57

miherlosev changed the title ~~add support for 'clientScripts' in configuration.~~ [WIP] Add support for 'clientScripts' Jun 28, 2019

miherlosev force-pushed the feature/additional-scripts branch from d9a799c to 35ba768 Compare June 28, 2019 08:01

AndreyBelym added this to the Sprint #36 milestone Jul 1, 2019

miherlosev force-pushed the feature/additional-scripts branch from a3f41f8 to 9fe10d6 Compare July 3, 2019 09:58

kirovboris approved these changes Jul 24, 2019

View reviewed changes

Ben Monro and others added 18 commits July 24, 2019 13:56

initial

7e947dd

fix wrong rebase

8701be7

new logic for resolving relative paths (test api and others)

0c80eaf

refactoring

452bd2f

fix tests

6402677

provide error messages for uncaught errors occured in injected client…

1f52eb7

… scripts

fix tests

b694730

fix error messages

1064300

fix server tests

0a51d4f

fix relative paths

31e8546

fix type definition

83e1d96

prevent multiple method calls for clientScripts and requestHooks

63006a5

fix an error message during module loading

aba412b

specify execution order for clientScripts and requestHooks

4d7253d

skip test

8e2f978

skip test

3d499cc

refix the test

11d30e0

fix client scripts loading order and handle module path resolving errors

3226191

miherlosev force-pushed the feature/additional-scripts branch from 05fe0ab to 3226191 Compare July 24, 2019 10:57

miherlosev merged commit 8c6e721 into DevExpress:master Jul 24, 2019

Conversation

benmonro commented Jun 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

testcafe-build-bot commented Jun 10, 2019

Uh oh!

testcafe-build-bot commented Jun 10, 2019

Uh oh!

testcafe-build-bot commented Jun 10, 2019

Uh oh!

miherlosev commented Jun 13, 2019

Uh oh!

benmonro commented Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

testcafe-build-bot commented Jun 17, 2019

Uh oh!

testcafe-build-bot commented Jun 24, 2019

Uh oh!

testcafe-build-bot commented Jun 25, 2019

Uh oh!

testcafe-build-bot commented Jun 25, 2019

Uh oh!

testcafe-build-bot commented Jun 26, 2019

Uh oh!

testcafe-build-bot commented Jun 26, 2019

Uh oh!

testcafe-build-bot commented Jun 27, 2019

Uh oh!

testcafe-build-bot commented Jun 27, 2019

Uh oh!

testcafe-build-bot commented Jun 28, 2019

Uh oh!

testcafe-build-bot commented Jun 28, 2019

Uh oh!

testcafe-build-bot commented Jun 28, 2019

Uh oh!

testcafe-build-bot commented Jul 1, 2019

Uh oh!

testcafe-build-bot commented Jul 1, 2019

Uh oh!

testcafe-build-bot commented Jul 2, 2019

Uh oh!

testcafe-build-bot commented Jul 2, 2019

Uh oh!

testcafe-build-bot commented Jul 2, 2019

Uh oh!

testcafe-build-bot commented Jul 2, 2019

Uh oh!

testcafe-build-bot commented Jul 3, 2019

Uh oh!

testcafe-build-bot commented Jul 22, 2019

Uh oh!

miherlosev commented Jul 23, 2019

Uh oh!

testcafe-build-bot commented Jul 23, 2019

Uh oh!

testcafe-build-bot commented Jul 23, 2019

Uh oh!

testcafe-build-bot commented Jul 23, 2019

Uh oh!

miherlosev commented Jul 24, 2019

Uh oh!

testcafe-build-bot commented Jul 24, 2019

Uh oh!

testcafe-build-bot commented Jul 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

benmonro commented Jun 10, 2019 •

edited

Loading

benmonro commented Jun 13, 2019 •

edited

Loading