[codex] Handle missing schedule alarm fallback#366
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 6f0cc0c): https://ontime-c63f1--pr366-codex-issue-363-alar-z9u5hh1n.web.app (expires Tue, 12 May 2026 05:50:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
|
Visit the preview URL for this PR (updated for commit 6f0cc0c): https://on-time-front-widgetbook--pr366-codex-issue-363-alar-r3tk058r.web.app (expires Tue, 12 May 2026 05:50:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/alarmScreenback to/homewhen the schedule state is alreadynotExistson entry./earlyLatefor real finish transitions.notExists.plans/.Fixes #363
Validation
flutter test test/presentation/alarm/screens/preparation_flow_widget_test.dartdart analyze lib/presentation/alarm/screens/alarm_screen.dart test/presentation/alarm/screens/preparation_flow_widget_test.dart(only pre-existing deprecation infos in the test file)Notes
flutter analyzeis currently blocked by unrelated existing repo/widgetbook errors, including missingwidgetbook_workspace/dialog_story_helpers.dartand generatedmain.directories.g.dart.