Skip to content

[codex] Fix preparation start boundary#367

Merged
jjoonleo merged 1 commit into
mainfrom
codex/fix-preparation-boundary
May 5, 2026
Merged

[codex] Fix preparation start boundary#367
jjoonleo merged 1 commit into
mainfrom
codex/fix-preparation-boundary

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • handle schedules received exactly at preparationStartTime through the official ScheduleStarted path
  • defensively start schedules when a timer target is already at or before now
  • add boundary tests for exact receive and early-start sessions

Fixes #362

Validation

  • flutter test test/presentation/app/bloc/schedule/schedule_bloc_test.dart
  • dart analyze lib/presentation/app/bloc/schedule/schedule_bloc.dart test/presentation/app/bloc/schedule/schedule_bloc_test.dart
  • git diff --check

Note: full flutter analyze still reports existing unrelated widgetbook/generated-file errors.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 2794529):

https://ontime-c63f1--pr367-codex-fix-preparatio-8op6tkpl.web.app

(expires Tue, 12 May 2026 05:49:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 2794529):

https://on-time-front-widgetbook--pr367-codex-fix-preparatio-v8jskhwq.web.app

(expires Tue, 12 May 2026 05:50:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 5, 2026 06:05
@jjoonleo jjoonleo merged commit cb96df2 into main May 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle exact preparation start boundary in ScheduleBloc

1 participant