Skip to content

[codex] refine startup flow#370

Merged
jjoonleo merged 1 commit into
mainfrom
codex/refine-startup-flow
May 5, 2026
Merged

[codex] refine startup flow#370
jjoonleo merged 1 commit into
mainfrom
codex/refine-startup-flow

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Refines the app startup flow so launch resolves through a stable startup phase instead of bouncing between /home, sign-in, onboarding, and notification routes.

What changed

  • Added an explicit auth loading state before persisted user resolution completes.
  • Added a /startup screen and made it the initial route.
  • Refactored router redirects into synchronous phase-based guards.
  • Added a notification gate cubit with persistent Do it later handling.
  • Moved notification initialization out of main.dart and into the notification gate.
  • Changed onboarding intro navigation from push to go and added submit loading/error handling.
  • Added the startup-flow refinement plan under plans/.

Why

The previous flow started at /home while auth was seeded as unauthenticated, so returning users could briefly see sign-in or experience route churn before the real auth state arrived. Notification permission was also checked inside router redirects, making post-sign-in and direct-home behavior inconsistent.

Validation

  • dart analyze on changed files: passed
  • flutter test: passed

Note: full flutter analyze still reports existing Widgetbook generated/import issues and unrelated pre-existing warnings.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 6a9ea14):

https://ontime-c63f1--pr370-codex-refine-startup-mk0uvwlw.web.app

(expires Tue, 12 May 2026 15:42:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 6a9ea14):

https://on-time-front-widgetbook--pr370-codex-refine-startup-2bozcmly.web.app

(expires Tue, 12 May 2026 15:42:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 5, 2026 15:48
@jjoonleo jjoonleo merged commit 39b3cc6 into main May 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant