[codex] refine startup flow#370
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 6a9ea14): https://ontime-c63f1--pr370-codex-refine-startup-mk0uvwlw.web.app (expires Tue, 12 May 2026 15:42:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
|
Visit the preview URL for this PR (updated for commit 6a9ea14): https://on-time-front-widgetbook--pr370-codex-refine-startup-2bozcmly.web.app (expires Tue, 12 May 2026 15:42:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refines the app startup flow so launch resolves through a stable startup phase instead of bouncing between
/home, sign-in, onboarding, and notification routes.What changed
/startupscreen and made it the initial route.Do it laterhandling.main.dartand into the notification gate.pushtogoand added submit loading/error handling.plans/.Why
The previous flow started at
/homewhile auth was seeded as unauthenticated, so returning users could briefly see sign-in or experience route churn before the real auth state arrived. Notification permission was also checked inside router redirects, making post-sign-in and direct-home behavior inconsistent.Validation
dart analyzeon changed files: passedflutter test: passedNote: full
flutter analyzestill reports existing Widgetbook generated/import issues and unrelated pre-existing warnings.