Skip to content

feat: 게시판 카테고리 선택하는 탭을 구현해요. - 1#194

Merged
Virtuso1225 merged 1 commit intodevfrom
feat/community-1
Mar 10, 2025
Merged

feat: 게시판 카테고리 선택하는 탭을 구현해요. - 1#194
Virtuso1225 merged 1 commit intodevfrom
feat/community-1

Conversation

@Virtuso1225
Copy link
Contributor

📌 내용

우선 게시판 카테고리 선택을 하는 탭을 구현했어요. 기존의 버튼 컴포넌트를 활용했어요.

스크린샷 2025-03-02 오전 12 46 45

☑️ 체크 사항

  • [ ]

❗ Related Issues

@Virtuso1225 Virtuso1225 self-assigned this Mar 1, 2025
@Virtuso1225 Virtuso1225 changed the title feat: 게시판 카테고리 선택하는 탭을 구현해요. feat: 게시판 카테고리 선택하는 탭을 구현해요. - 1 Mar 1, 2025
Copy link
Member

@halionaz halionaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key값만 추가해주세오

Comment on lines +41 to +47
<Button
variant="default"
isActive={queryParam.board === board.board}
onClick={() => setQueryParam({ board: board.board, boardId: board.boardId })}
>
{board.displayText}
</Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button
variant="default"
isActive={queryParam.board === board.board}
onClick={() => setQueryParam({ board: board.board, boardId: board.boardId })}
>
{board.displayText}
</Button>
<Button
key={뭔가-까리한-key-prop}
variant="default"
isActive={queryParam.board === board.board}
onClick={() => setQueryParam({ board: board.board, boardId: board.boardId })}
>
{board.displayText}
</Button>

Copy link
Member

@halionaz halionaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 PR에서 key값 추가하길래 어뿌루부

@Virtuso1225 Virtuso1225 merged commit 79def9e into dev Mar 10, 2025
1 check passed
@Virtuso1225 Virtuso1225 deleted the feat/community-1 branch March 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants