Skip to content

소소한 수정 (1분 PR 가능)#112

Merged
halionaz merged 2 commits into
devfrom
fix/#111
Aug 1, 2025
Merged

소소한 수정 (1분 PR 가능)#112
halionaz merged 2 commits into
devfrom
fix/#111

Conversation

@halionaz

@halionaz halionaz commented Aug 1, 2025

Copy link
Copy Markdown
Member

❗ 연관 이슈

📌 내용

  • 디테일 페이지 하단 바가 데스크탑에서 개크게 나오는 버그 수정
  • 디테일 페이지 스크롤이 있는 경우에 하단바를 넘어서서 겹쳐지는 버그 수정
  • Pick Page 라우트 수정, 이제 핔페이지 접속하려고 하면 로그인하라고 나옴

Before

Screenshot 2025-08-01 at 4 02 14 PM

After

Screenshot 2025-08-01 at 4 02 45 PM

@halionaz halionaz requested review from Copilot and jw0202058 August 1, 2025 07:04
@halionaz halionaz self-assigned this Aug 1, 2025
@netlify

netlify Bot commented Aug 1, 2025

Copy link
Copy Markdown

Deploy Preview for repicka ready!

Name Link
🔨 Latest commit 171503d
🔍 Latest deploy log https://app.netlify.com/projects/repicka/deploys/688c66f494ac540008f5ab0b
😎 Deploy Preview https://deploy-preview-112--repicka.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@halionaz halionaz changed the title 소소한 수정 소소한 수정 (1분 PR 가능) Aug 1, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses UI bugs in the detail page layout and updates route configuration. The changes fix bottom bar sizing issues on desktop and overlapping scroll content, while also restricting access to the pick page by requiring authentication.

  • Fixed detail page bottom bar appearing oversized on desktop
  • Resolved scroll content overlapping with bottom bar
  • Updated pick page routing to require login authentication

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/pages/routes.tsx Removed direct route to pick page to enforce authentication
src/pages/DetailPage/style.css.ts Updated scroll container height and padding to prevent overlap
src/features/detail/components/BottomActions/style.css.ts Changed positioning from fixed to absolute for better layout

Comment thread src/pages/DetailPage/style.css.ts

@jw0202058 jw0202058 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good이에욥

@halionaz halionaz merged commit bab8d43 into dev Aug 1, 2025
4 checks passed
@halionaz halionaz deleted the fix/#111 branch August 1, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

아이템 상세 페이지 스크롤바 이상함 Position Fixed -> Absolute

3 participants