feat: chip 구현구현#13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new reusable Chip component with color variants and integrates it into the HomePage.
- Adds a Chip component in
src/common/components/Chipwithgrayandredvariants. - Defines styling for the Chip via
cvain a newstyle.css.ts. - Imports and displays a red “축구” Chip on the HomePage.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/components/Chip/style.css.ts | Defines base styles and gray/red variants with cva |
| src/common/components/Chip/index.tsx | Implements the Chip component API (children, color, onClick) |
| src/pages/HomePage/index.tsx | Imports and renders the new Chip on the HomePage |
Comments suppressed due to low confidence (2)
src/common/components/Chip/index.tsx:1
- Add unit tests (e.g., with React Testing Library) to cover rendering of each color variant and verify onClick behavior for the Chip component.
import type { PropsWithChildren } from 'react';
src/common/components/Chip/index.tsx:1
- [nitpick] Include JSDoc or inline comments to document the Chip component's props (
color,children,onClick) and explain available variants.
import type { PropsWithChildren } from 'react';
jw0202058
approved these changes
Jul 1, 2025
feat: dropdown 구현구현
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ 연관 이슈
📌 내용
☑️ 체크 사항 & 논의 사항