Skip to content

feat: chip 구현구현#13

Merged
halionaz merged 6 commits into
devfrom
feat/#12/chip
Jul 1, 2025
Merged

feat: chip 구현구현#13
halionaz merged 6 commits into
devfrom
feat/#12/chip

Conversation

@halionaz

Copy link
Copy Markdown
Member

❗ 연관 이슈

📌 내용

  • 구현했삼...

☑️ 체크 사항 & 논의 사항

  • 잘되나
  • [ ]

@halionaz halionaz requested review from Copilot and jw0202058 June 30, 2025 10:36
@halionaz halionaz self-assigned this Jun 30, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new reusable Chip component with color variants and integrates it into the HomePage.

  • Adds a Chip component in src/common/components/Chip with gray and red variants.
  • Defines styling for the Chip via cva in a new style.css.ts.
  • Imports and displays a red “축구” Chip on the HomePage.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/common/components/Chip/style.css.ts Defines base styles and gray/red variants with cva
src/common/components/Chip/index.tsx Implements the Chip component API (children, color, onClick)
src/pages/HomePage/index.tsx Imports and renders the new Chip on the HomePage
Comments suppressed due to low confidence (2)

src/common/components/Chip/index.tsx:1

  • Add unit tests (e.g., with React Testing Library) to cover rendering of each color variant and verify onClick behavior for the Chip component.
import type { PropsWithChildren } from 'react';

src/common/components/Chip/index.tsx:1

  • [nitpick] Include JSDoc or inline comments to document the Chip component's props (color, children, onClick) and explain available variants.
import type { PropsWithChildren } from 'react';

Comment thread src/common/components/Chip/index.tsx Outdated
@halionaz halionaz merged commit 01ad4b1 into dev Jul 1, 2025
@halionaz halionaz deleted the feat/#12/chip branch July 1, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

공용 컴포넌트 구현 (칩)

3 participants