검색 필터 구현 구현 !#136
Conversation
✅ Deploy Preview for repicka ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a filter reset button and price filtering functionality. It adds visual indicators to filter buttons showing selected options and introduces a comprehensive price filter system with both preset ranges and custom input.
- Added filter reset button that clears all applied filters and shows total item count
- Implemented price filtering with preset ranges and custom price input
- Updated filter UI to display selected filter states with icons and counts
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/SearchPage/index.tsx | Added price parameters to search filters |
| src/features/home/components/Filter/index.tsx | Replaced Swiper with direct component rendering and added reset functionality |
| src/features/home/components/Filter/PriceFilter/index.tsx | New price filter component with preset ranges and custom input |
| src/features/home/components/SearchControls/index.tsx | Updated filter buttons to show selected state |
| src/common/components/SelectButton/index.tsx | Modified to display selected filter icons instead of arrow |
| src/common/components/TagOptionBtn/index.tsx | Exported Symbol component for reuse |
| }; | ||
|
|
||
| const submitPrice = () => { | ||
| if (isNaN(startPrice) || isNaN(endPrice)) return; | ||
| if (startPrice > endPrice) { | ||
| alert('시작 가격이 끝 가격보다 클 수 없습니다.'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Using alert() is not a good user experience practice. Consider using a toast notification or inline error message instead.
| }; | |
| const submitPrice = () => { | |
| if (isNaN(startPrice) || isNaN(endPrice)) return; | |
| if (startPrice > endPrice) { | |
| alert('시작 가격이 끝 가격보다 클 수 없습니다.'); | |
| return; | |
| } | |
| setErrorMessage(''); | |
| }; | |
| const submitPrice = () => { | |
| if (isNaN(startPrice) || isNaN(endPrice)) { | |
| setErrorMessage(''); | |
| return; | |
| } | |
| if (startPrice > endPrice) { | |
| setErrorMessage('시작 가격이 끝 가격보다 클 수 없습니다.'); | |
| return; | |
| } | |
| setErrorMessage(''); |
There was a problem hiding this comment.
토스트 알림 같은것도 하나 있으면 좋긴 하겠다
There was a problem hiding this comment.
토스트 알림 인정 정보 수정했을 때 띄워주면 좋을 듯
|
아이콘 겁내 귀엽다 ㅋㅋ |
나도 뭔가 그게 더 좋을 거 같은데 일단 FigDes는 비활 상태였다가 활성으로 바뀌는걸로 되어있길래 그렇게 해둠 가격필터 적용되는건 포커스 아웃됐을 때 |
❗ 연관 이슈
📌 내용
☑️ 체크 사항 & 논의 사항