Skip to content

[#96] 포스트 자잘구리한 디자인 수정#98

Merged
jw0202058 merged 5 commits into
devfrom
fix/#96/post-todo
Jul 27, 2025
Merged

[#96] 포스트 자잘구리한 디자인 수정#98
jw0202058 merged 5 commits into
devfrom
fix/#96/post-todo

Conversation

@jw0202058

Copy link
Copy Markdown
Collaborator

❗ 연관 이슈

📌 내용

  • 각종 제한 문구...
  • 잘못 건드려서 이상해진 레이아웃 정리
  • textareaautosize 라이브러리를 추가함 yarn ㄱㄱ

☑️ 체크 사항 & 논의 사항

  • 버그 없나요?
  • 디자인 같나요
  • [ ]

@netlify

netlify Bot commented Jul 24, 2025

Copy link
Copy Markdown

Deploy Preview for repicka ready!

Name Link
🔨 Latest commit d238a8e
🔍 Latest deploy log https://app.netlify.com/projects/repicka/deploys/6885a30eef49f600089e115f
😎 Deploy Preview https://deploy-preview-98--repicka.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jw0202058 jw0202058 requested a review from halionaz July 24, 2025 07:39
@jw0202058

jw0202058 commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator Author

쟤 뭔데 뭐... 뭐 어떻게 보는 건데 저 넷플릭스

@halionaz

Copy link
Copy Markdown
Member

넷플릭스 구독 안해서 에러뜨네

@halionaz

Copy link
Copy Markdown
Member

보니까 타입에러 있네요 yarn tsc -b로 에러찾아서 수정 고고곡

Comment on lines +1 to +18
// 채팅방 들어갔을 때 오는 값
import client from '@/common/utils/client';
import { useMutation } from '@tanstack/react-query';

const postChatRoom = async ({ chatRoomId }: { chatRoomId: number }) => {
const res = await client.post(`/api/v1/chatroom/${chatRoomId}/enter`, null, {
params: { pageSize: 5 },
});

console.log(res.data.message);

return res;
};

export const usePostChatRoom = () =>
useMutation({
mutationFn: postChatRoom,
});

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 브랜치랑 상관없는데 모르고 여기다 해 버렸네 무시해주삼

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무시 못해

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해줘

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알써

<span className="mgc_alert_octagon_fill"></span>
사진은 최대 6장까지 등록이 가능해요.
<AlertText isIcon={true}>최대 6장까지 등록이 가능해요</AlertText>
<AlertText isIcon={true}>장당 최대 5MB까지 등록이 가능해요.</AlertText>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얠 굳이 안 빼도 되려나

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이거 용량 제한 알려주는게 의미가 있나 고민이 되네

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭐 안 되는 이유를 알 수 있으니 괜찮지 않나


console.log(data);

return (

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘도 무시해주세염... 이거 하다가 찝찝하게 이제 약속 나갈 시간

@halionaz halionaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훈수 둘 게 없어서
꼬투리만 잡았어요

return (
<input
className={`${s.Container({ isNumber })} ${className}`}
className={`${s.Container({ isNumber })} ${className} ${s.ContainerWithPlaceholder}`}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 cx() 써서 묶어주는건 어떨까요

Comment on lines +28 to +32
export const ContainerWithPlaceholder = css({
_placeholder: {
color: '54',
},
});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이거 분리할 필요 없이 그냥 위 Container랑 합쳐도 된다 아님?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위 컨테이너는 cva라서 안 대요

import UploadFile from '../../UploadFile';
import { useStep5Store } from '@/features/post/stores/Step5Store';
import { ALLOWED_EXTENSIONS, MAX_DESC, MAX_SIZE_BYTES, MAX_SIZE_MB, MAX_TITLE } from '@/libs/constants';
import AlertText from '../../AlertText';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 너꺼 import 왜 자동으로 global path로 안 불러와지지

setValue={titleSetter}
maxLength={MAX_TITLE}
placeholder="최대 64자까지 입력이 가능해요."
></InputField>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
></InputField>
/>

😎

<span className="mgc_alert_octagon_fill"></span>
사진은 최대 6장까지 등록이 가능해요.
<AlertText isIcon={true}>최대 6장까지 등록이 가능해요</AlertText>
<AlertText isIcon={true}>장당 최대 5MB까지 등록이 가능해요.</AlertText>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이거 용량 제한 알려주는게 의미가 있나 고민이 되네

@jw0202058 jw0202058 merged commit c91e5f8 into dev Jul 27, 2025
@jw0202058 jw0202058 deleted the fix/#96/post-todo branch July 27, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants