fix: making the webpage more accessible #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for public-github-stats pending review.Visit the deploys page to approve it
|
Contributor
Author
|
Hi @Balastrong! :) My PR is ready for review! :) |
Balastrong
approved these changes
Feb 1, 2024
Member
Balastrong
left a comment
Balastrong
left a comment
There was a problem hiding this comment.
Thank you for the accessibility improvements! LGTM! :D
Member
|
@all-contributors please add @CBID2 for code a11y |
Contributor
|
I've put up a pull request to add @CBID2! 🎉 |
theflucs
pushed a commit
to theflucs/github-stats
that referenced
this pull request
Feb 5, 2024
* main: docs: add CBID2 as a contributor for code, and a11y (DevLeonardoCommunity#109) fix: making the webpage more accessible (DevLeonardoCommunity#105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR does the following changes to make the website more accessible:
#2d63bc. This helps the background color more readable to users with low-vision(see screenshot for reference)<label>elements in the headerfor=""attributes andaria-labelsThis make the header more semantic, thus easier for screen reader uses to navigate this part of the website.Screenshot
This one refers to the first proposed change.
This result refers to the second proposed change.
Related Tickets and Documents
Closes #103
Note to Reviewers
The PR is in draft mode because I'm still trying to figure out a way to implement a
<form>element without messing up the header.Update(1/31): I'm finished! :)