Bug/fix qa

[ViktorSvertoka]

Summary by CodeRabbit

• Bug Fixes

  • Improved question retrieval and pagination accuracy by implementing result deduplication.
  • Optimized total count calculation to work directly with deduplicated datasets.

• Chores

  • Updated cache versioning to maintain consistency.
  • Updated tests to align with revised question retrieval logic.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
devlovers-net	Ready	Preview, Comment	Feb 15, 2026 0:47am

[netlify]

✅ Deploy Preview for develop-devlovers ready!

Name	Link
🔨 Latest commit	15d8fae
🔍 Latest deploy log	https://app.netlify.com/projects/develop-devlovers/deploys/6991bff2e0c4fb00087f3e14
😎 Deploy Preview	https://deploy-preview-332--develop-devlovers.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

The API route for retrieving questions by category now deduplicates items before applying pagination, replacing a separate count query with a dedupe-based total calculation. The cache version is bumped from v2 to v3. Test cases are updated to reflect the modified query mock sequence and increased item counts in expected payloads.

Changes

Cohort / File(s)	Summary
API Route Pagination Logic frontend/app/api/questions/[category]/route.ts	Replaced count query with deduplication-based pagination; fetches all matching items, deduplicates, then slices for pagination results. Ordering adjusted to sort by sortOrder and id. Simplified payload construction using direct object instead of wrapper function.
Cache Version Update frontend/lib/cache/qa.ts	Bumped QA_CACHE_VERSION from 'v2' to 'v3', invalidating existing cache entries and affecting all cache key lookups.
Test Updates frontend/lib/tests/q&a/questions-route.test.ts	Updated mock sequences from where to orderBy in query builder chains; adjusted expected payload item counts from 1 to 2 in affected test cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• (SP:2) [Frontend] Fix duplicated Q&A items after content updates #330 — Modifies the same API route to add/adjust deduplication of Q&A items and update QA cache handling/versioning.
• (SP: 2) [QA] Q&A Tests & Coverage #208 — Changes /api/questions/[category] route implementation affecting pagination and deduplication behavior tested in updated test cases.
• feat(Blog):Adding pagination #244 — Modifies frontend/app/api/questions/[category]/route.ts and related QA caching/pagination logic with similar deduplication and cache integration.

Suggested labels

bug

Suggested reviewers

• AM1007

Poem

🐰 Deduplicate, deduplicate with care,
Fetch all items floating in the air,
Cache version three, a fresh new key,
Pagination cleaner, now we agree!
Tests align with orderBy's grace, ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Bug/fix qa' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific changes in the changeset.	Use a more descriptive title that specifies the actual bug fix or improvement, such as 'Refactor QA endpoint pagination to use deduplication' or 'Fix QA questions endpoint query logic and caching'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into develop

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bug/fix-qa

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

frontend/lib/cache/qa.ts (1)

55-77: ⚠️ Potential issue | 🟠 Major

invalidateQaCacheByCategory prefix doesn't include the version segment — keys will never match.

The SCAN pattern on Line 59 is qa:category:${category}:*, but buildQaCacheKey produces keys like qa:v3:category:${category}:.... The prefix mismatch means this function silently deletes nothing.

This bug predates this PR, but since you're bumping the cache version and actively working in this file, it's a good time to fix it.

Proposed fix

 export async function invalidateQaCacheByCategory(category: string) {
   const redis = getRedisClient();
   if (!redis) return 0;

-  const prefix = `qa:category:${category.toLowerCase()}:`;
+  const prefix = `qa:${QA_CACHE_VERSION}:category:${category.toLowerCase()}:`;
   let cursor = 0;
   let deleted = 0;

frontend/app/api/questions/[category]/route.ts (1)

142-163: ⚠️ Potential issue | 🟠 Major

Fetching all matching rows into memory may not scale well.

The query now retrieves every row for a category+locale (no DB-level LIMIT), deduplicates in JS, then slices. This works fine for small datasets but becomes a concern if a category grows to thousands of questions — every paginated request pays the full fetch cost.

If the duplicate problem originates from the DB (e.g., missing unique constraint or bad join fan-out), consider fixing it at the source. Otherwise, if the dataset is known to be small and bounded, a short comment documenting that assumption would help future maintainers.

🧹 Nitpick comments (2)

frontend/app/api/questions/[category]/route.ts (1)

53-69: normalizeResponse is now only used for re-deduping cached payloads.

Since fresh responses are already deduped before caching (Lines 160, 176), normalizeResponse only serves as a safety net for stale v2 cache entries that might still be in Redis. After the v3 cache version bump, old entries won't be read anymore, making this function effectively dead code going forward.

Consider removing it in a follow-up cleanup once you're confident no v2 keys remain.

frontend/lib/tests/q&a/questions-route.test.ts (1)

132-186: Deduplication test is well-structured.

Good coverage: feeds 3 items (two with identical question text) and asserts only 2 unique items come through, with correct total and cache write.

Consider adding a test for pagination after dedup (e.g., 5 unique items with limit=2&page=2) to verify the in-memory slicing logic produces the correct page.