Skip to content

Added SLA in the footer#203

Merged
Aleksandergreg merged 2 commits into
mainfrom
dev
Jun 25, 2025
Merged

Added SLA in the footer#203
Aleksandergreg merged 2 commits into
mainfrom
dev

Conversation

@Luke3520
Copy link
Copy Markdown
Contributor

@Luke3520 Luke3520 commented Jun 25, 2025

Description

Changed footer to also show SLA, as the users didn't have any way of reaching this endpoint, but by typing it manually.

Related Issue:
Fixes #197

Type of Change

  • Bug fix: Non-breaking change which fixes an issue.
  • New feature: Non-breaking change which adds functionality.
  • Breaking change: Fix or feature that would cause existing functionality to change.
  • Documentation update: Changes to documentation only.

How Has This Been Tested?

It has been ran locally in our Docker.dev enviroment, to ensure that the link works properly.

Checklist

Before creating this pull request, please ensure that your code meets the following requirements:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

Summary by CodeRabbit

  • New Features
    • Added an "SLA" link to the footer, alongside the existing "About" link.

Aleksandergreg and others added 2 commits June 24, 2025 16:00
@Luke3520 Luke3520 requested a review from Aleksandergreg June 25, 2025 08:38
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Jun 25, 2025

Here's the code health analysis summary for commits 9619b25..4419cba. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Ruby LogoRuby✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Luke3520 Luke3520 added the ruby Pull requests that update ruby code label Jun 25, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 25, 2025

Walkthrough

The footer in the main layout template was updated to include a new "SLA" hyperlink pointing to "/sla" alongside the existing "About" link. No other aspects of the layout or application logic were changed.

Changes

File(s) Change Summary
sinatra/views/layout.erb Added "SLA" link after "About" link in the footer.

Possibly related PRs

Poem

In the footer’s gentle glow,
A new link starts to show—
“SLA” beside “About,”
Now users have no doubt.
With every hop and every click,
This rabbit’s code is quick!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
sinatra/views/layout.erb (1)

45-45: Trim trailing whitespace after the new link

There’s a single space after </a> that isn’t needed and may cause diff noise later.

-      <a href="/sla">SLA</a> 
+      <a href="/sla">SLA</a>
📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9619b25 and 4419cba.

📒 Files selected for processing (1)
  • sinatra/views/layout.erb (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: e2e
🔇 Additional comments (1)
sinatra/views/layout.erb (1)

44-45: ```shell
#!/bin/bash

Search for an explicit Sinatra route for /sla

rg -n "get\s+['"]/sla['"]"

Search for any catch-all or dynamic page route (e.g., get '/:page')

rg -n "get\s+['"]/:\w+['"]" -A2 -B2

Look for a static SLA file in the public directory

fd -e html sla public


</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@Aleksandergreg Aleksandergreg merged commit 81e5aa6 into main Jun 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update ruby code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make footer contain SLA hyperlink

2 participants