Skip to content

Add OIDC-based tenant auth and RBAC enforcement#39

Closed
DevOpsMadDog wants to merge 1 commit into
mainfrom
codex/extend-overlay-schema-for-tenant-identity
Closed

Add OIDC-based tenant auth and RBAC enforcement#39
DevOpsMadDog wants to merge 1 commit into
mainfrom
codex/extend-overlay-schema-for-tenant-identity

Conversation

@DevOpsMadDog
Copy link
Copy Markdown
Owner

Summary

  • extend the overlay tenancy schema to merge tenant identity providers, allowed audiences, and storage directories
  • add OIDC bearer token verification, tenant-specific storage, and RBAC enforcement for uploads and pipeline runs
  • cover the new authentication flow with integration tests exercising OIDC success and failure scenarios

Testing

  • pytest tests/test_end_to_end.py

https://chatgpt.com/codex/tasks/task_e_68e1bb2266e083298e97ef4d94eaff5e

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread backend/app.py
Comment on lines +266 to +270
required = roles_config.get(action)
if required is None:
fallback_map = {
"upload": ("uploads", "ingest", "write"),
"pipeline": ("run", "execute", "pipeline_run"),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Enforce fallback to default RBAC roles

The RBAC check only looks up the action-specific key (e.g. upload) and a small alias map. When overlay configuration supplies roles as a simple list, _normalise_overlay stores them under roles.default (see fixops/configuration.py where non‑mapping roles are normalized to a "default" key). Because _enforce_rbac never consults this default entry, such tenants end up with no required roles and any bearer token is accepted. Add a lookup for roles_config.get("default") so that default roles are enforced for actions unless an explicit override exists.

Useful? React with 👍 / 👎.

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Closing as part of PR consolidation. Useful changes have been cherry-picked into PR #240.

DevOpsMadDog added a commit that referenced this pull request May 5, 2026
…2030f7a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant