fix(notify-irm): remove ${{ }} templates from description blocks#53
Merged
DevSecNinja merged 1 commit intomainfrom May 1, 2026
Merged
fix(notify-irm): remove ${{ }} templates from description blocks#53DevSecNinja merged 1 commit intomainfrom
DevSecNinja merged 1 commit intomainfrom
Conversation
GitHub Actions evaluates ${{ }} expressions inside action.yml even
within description blocks, so the documentation example containing
always() (only valid in workflow if: contexts) caused every consumer
workflow to fail with:
Unrecognized function: 'always'.
Located at position 1 within expression:
always() && github.ref == 'refs/heads/main' && ...
Move the example into a sibling README.md and keep the description text
template-free.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every consumer of
notify-irmis failing at action-load time with:Root cause
GitHub Actions runs the template engine over
action.ymlin full — including thedescription:block. The usage example I embedded in the description contained${{ always() && github.ref == ... }}, andalways()is only valid in workflowif:contexts. The engine rejected the expression and refused to load the manifest, so every workflow that diduses: DevSecNinja/.github/.github/actions/notify-irm@<sha>failed.Fix
${{ }}expressions out ofdescription:blocks inaction.yml.README.md(where it can use${{ }}freely because it isn't templated).Verification
runs.steps[0]still uses${{ inputs.* }}and${{ github.* }}— those are valid in composite steps and were never the problem.truenas-apps#306anddotfiles#255) will load the action successfully and their existing SHA pins (a877d352…) only need to be bumped to the merge SHA of this PR.