fix(test): make the branch guard ordering test line-ending agnostic - #629
Merged
Conversation
The test introduced in #623 matched against 'Test-ChezmoiSourceBranch' + [Environment]::NewLine. .gitattributes pins *.ps1 to eol=crlf, so the working tree is CRLF on every OS, while [Environment]::NewLine is LF on Linux and macOS - so the match only ever succeeded on Windows. CI runs the Pester suite on Windows, which is why this passed review and still broke main for anyone running the suite on Linux or macOS. Normalise CRLF to LF before matching instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test added in #623 fails on Linux and macOS. It is currently red on
main.Cause
.gitattributespins*.ps1toeol=crlf, so the working tree is CRLF on every OS — but[Environment]::NewLineis LF on Linux/macOS. The match therefore only ever succeeded on Windows.CI runs the Pester suite on Windows, which is why this passed review and still broke
mainfor anyone running the suite locally on Linux or macOS.Reproduced on a clean clone of
main:Fix
Normalise CRLF to LF before matching. My bug from #623.
Verification
[Environment]::NewLineis ininstall.ps1, where it is correct (joining output for display)Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com