fix(release): trigger on tag push instead of release:created#263
Merged
DevSecNinja merged 1 commit intomainfrom May 1, 2026
Merged
fix(release): trigger on tag push instead of release:created#263DevSecNinja merged 1 commit intomainfrom
DevSecNinja merged 1 commit intomainfrom
Conversation
The release-please post-merge run for v0.2.0 created the draft GitHub Release as expected, but \`release.yml\` listening on \`release: created\` did not fire. The tag push from the same release-please run DID trigger \`devcontainer-prebuild\` (which listens on \`push: tags\`), confirming that App-token tag pushes propagate reliably while App-token release events do not. Switch to \`push: tags v*\` and look up the existing draft body via \`gh release view --json body\`. This makes the trigger as reliable as any other tag-driven workflow in the repo. Add \`workflow_dispatch\` with a \`tag\` input so a failed run can be retried against any tag without a fresh release-please bump.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release-please post-merge run for
v0.2.0(#250) tagged the commit and created the draft GitHub Release as designed, butrelease.ymllistening onrelease: createddid not fire. Meanwhiledevcontainer-prebuild.yml, which listens onpush: tags, did fire on the same tag — so App-token tag pushes propagate reliably while App-tokenreleaseevents do not.This is a long-standing intermittent issue with release-please + GitHub App tokens.
What
push: tags - "v*".github.event.release.bodywithgh release view --json body --jq .bodyso the workflow fetches release-please's draft body for the tag at runtime.workflow_dispatchwith ataginput so failed runs can be retried against any tag without a fresh release-please bump.if: github.event.release.draftgate on the release job (no longer applicable; the tag-push trigger doesn't carry that field). The notify-irm job'sifis updated to fire only onpushevents so manualworkflow_dispatchreruns don't page.Unsticking v0.2.0
After this PR merges:
That dispatches the workflow against
v0.2.0, which will find the existing draft Release, build/attest/upload assets, and flip it to published.