ci: drop redundant push:main trigger and remove unreachable notify-irm#266
Merged
DevSecNinja merged 1 commit intomainfrom May 1, 2026
Merged
ci: drop redundant push:main trigger and remove unreachable notify-irm#266DevSecNinja merged 1 commit intomainfrom
DevSecNinja merged 1 commit intomainfrom
Conversation
Branch protection ensures the merge commit on main is identical to the last PR head, so re-running CI on push:main is duplicate work and adds noise (especially with rapid follow-up commits triggering both PR and main runs). The notify-irm job gated on github.ref == 'refs/heads/main' is now unreachable without the push:main trigger; remove it. Pages on PR-validation workflows are low-value anyway (PRs cannot merge if checks fail). Pages on deploy/release workflows still fire on main breakage. See DevSecNinja/.github docs/workflow-trigger-conventions.md (forthcoming).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ci.yamlruns on every PR commit AND again on push to main. With branch protection ensuring the merge commit is identical to the last PR head, the post-merge run is duplicate work — and a small flurry of commits causes CI, docs, and label-sync to all churn.What
push: branches: [main]fromci.yaml. PR-only (plusworkflow_dispatch).notify-irmjob: gated ongithub.ref == 'refs/heads/main' && github.event_name == 'push', so without push:main it's unreachable. Pages on PR-validation workflows are low-value anyway (PRs cannot merge if checks fail). Pages on deploy/release workflows still fire on main breakage.The existing workflow-level concurrency block already cancels superseded runs.
Followup
A forthcoming doc in
DevSecNinja/.githubwill codify this as an org-wide convention.Mirrors DevSecNinja/truenas-apps#325.