Conversation
- cmd/test-adapter: manual adapter testing utility - cmd/test-rbac: manual RBAC testing utility
- build.sh (duplicated with Makefile) - validate-eslint.sh, validate-checkstyle.sh - installers/ (replaced by npm publish)
- Consolidate test data under tests/ directory - Update documentation references
- Add prerequisites section with required tools - Add external tools auto-installation info - Add troubleshooting section
- Delete engine.go (unused Engine interface, EngineRegistry) - Delete CanAutoFix() stub method - Delete AutoFix() stub method
- Remove Validate() method that was not used anywhere in production code - Remove Result struct that was only used by Validate() - Remove checkRBAC() and selectFilesForRule() helper methods - ValidateChanges() is the active API for git change validation
- Remove IsAdmin() function marked as deprecated - Function was unused across entire codebase - Replaced by RBAC canEditPolicy permission system
- Remove Loader.verbose field that was never read - Remove SaveCodePolicy() method that was never called - Remove ApplyTemplate() wrapper function (use GetTemplate directly)
Remove HTTP mode components: - Delete startHTTPServer, handleHealthCheck, handleHTTPRequest methods - Delete handleInitialize, handleToolsList, handleToolsCall methods - Delete JSONRPCRequest, JSONRPCResponse types (keep RPCError for internal use) - Remove Server.host field - Update NewServer signature (remove host parameter) - Simplify Start() method to stdio-only - Update cmd/mcp.go to remove --host flag Remove incomplete test: - Delete TestFilterConventionsWithDefaults and helper types - Test only logged JSON without assertions MCP server now uses stdio mode exclusively for integration with Claude Desktop, Claude Code, Cursor, and other MCP clients.
Remove unused exported symbols that were never called: - WithMaxTokens() - default value always used - WithTemperature() - default value always used - WithVerbose() - never enabled - CheckAvailability() - never integrated into workflow Active API remains: NewClient, WithModel, WithTimeout, Complete
Remove TokenType and Scope fields from OAuthTokenResponse struct. These fields were decoded from JSON but never read or used anywhere. Only AccessToken is needed for the OAuth flow.
- LanguageLinterMapping, LLMValidatorEngine를 unexport - CheckstyleModule, CheckstyleProperty, CheckstyleConfig를 unexport - PMDRuleset, PMDRule를 unexport
- EnsureConfigDir → ensureConfigDir (내부에서만 사용)
- README.md: remove all emojis, remove deleted testdata/engine references - AGENTS.md: complete incomplete final sentence - docs/CONVERT_FEATURE.md: translate to Korean - docs/CONVERT_USAGE.md: translate to Korean, remove deleted testdata reference - docs/LINTER_VALIDATION.md: translate to Korean, remove deleted testdata references - tests/TESTING_GUIDE.md: remove deleted testdata section
- Reduce from 703 to 125 lines - Move quick start guide to top - MCP auto-configured during init - Remove redundant content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
scripts/,examples/,testdata/cmd/test-adapter/,cmd/test-rbac/validator.go,export.go, HTTP modeIsAdmin,Validate,ResultEnsureConfigDir, response types, registry errorsSETUP.md를README.md에 병합 후 삭제