Skip to content

Feat/integrate symphony client#3

Merged
sehwan505 merged 19 commits intomainfrom
feat/integrate-symphony-client
Nov 3, 2025
Merged

Feat/integrate symphony client#3
sehwan505 merged 19 commits intomainfrom
feat/integrate-symphony-client

Conversation

@baeyc0510
Copy link
Copy Markdown
Contributor

@baeyc0510 baeyc0510 commented Nov 2, 2025

🎵 Summary

Integrated symphonyclient (GitHub RBAC and policy management) into sym-cli (code convention validation), creating a unified tool named Symphony (sym).

✨ Key Changes

🔗 Integration Architecture

  • Unified binary: Single sym command for all features
  • Preserved functionality: All features from both projects maintained
  • Consistent naming: symphony → sym commands
  • Unified paths: .github/ → .sym/ directory

📦 Major Features Added

1. RBAC & Role Management

  • GitHub OAuth authentication (server & custom modes)
  • Dynamic role system with custom role creation
  • User and role management via CLI and dashboard
  • Commands: login, logout, whoami, my-role, init

2. Web Dashboard (Port 8787)

  • Policy editor with RBAC configuration
  • Real-time saving with auto-save (30s interval)
  • Template system (React, Vue, Node.js, Python, Go, TypeScript)
  • Git-based policy history tracking
  • Permission-based UI (read-only mode for non-editors)
  • SVG icons and Tailwind CSS

3. Schema Extension

  • Extended UserPolicy with canEditPolicy, canEditRoles
  • Added no (rule number) and example fields to UserRule
  • Maintained A/B schema separation (user input vs validation engine)

🔧 Technical Improvements

Build System

  • Integrated Tailwind CSS build pipeline
  • Windows: automatic .exe extension
  • Multi-platform support (Linux, macOS, Windows)
  • CSS auto-build on make build

Directory & Configuration

  • Policy files: .sym/user-policy.json, .sym/roles.json
  • Config: ~/.config/sym/ (was ~/.config/symphony/)
  • Tool dirs: ~/.sym/tools, ~/.sym/cache
  • Environment vars: SYM_AUTH_MODE, SYM_SERVER_URL

UI/UX

  • Unified category colors (gray instead of per-category colors)
  • Auto-save functionality (30 seconds)
  • Updated placeholders and help text
  • Consistent .sym/ references throughout

📝 Documentation

  • Complete README rewrite with integrated features
  • Added .sym/ to .gitignore
  • Updated all examples and usage guides
  • Noted work-in-progress features

🔄 Migration Path

From symphonyclient:

# Old
symphony login
symphony init
symphony dashboard

# New
sym login
sym init
sym dashboard

File locations:

  • .github/roles.json → .sym/roles.json
  • .github/user-policy.json → .sym/user-policy.json
  • ~/.config/symphony/ → ~/.config/sym/

📊 Commits (18 total)

  1. 140ea08 - Extended UserPolicy schema
  2. 412e57e - Copied symphonyclient packages
  3. 13d4e8e - Added dependencies & build config
  4. 11673e3 - Updated import paths
  5. efa9cf1 - Changed paths: .github → .sym
  6. 289a7f1 - Changed config directory
  7. 40dba53 - Integrated commands & changed port to 8787
  8. 5a455b9 - Merged policy package with schema
  9. 8280761 - Added CSS build targets
  10. 0bf94d5 - Fixed build errors
  11. abfb154 - Fixed environment variables & paths
  12. 1645f7d - Updated tool directories
  13. 012ff26 - Fixed Windows .exe extension
  14. b9110e0 - Unified category colors to gray
  15. 62840f1 - Implemented auto-save feature
  16. d56161d - Updated UI placeholders
  17. 8339a0c - Updated README & gitignore
  18. 81889f0 - Added package-lock.json

✅ Testing

  • Build succeeds on Windows (bin/sym.exe 11MB)
  • All symphonyclient features work (dashboard, login, roles)
  • All sym-cli structures preserved (engines, adapters, schema)
  • No .github references in user-facing code
  • Environment variables consistent (SYM_*)
  • Auto-save works (30s interval)
  • Category colors unified (gray)

⚠️ Notes

  • Code validation features (convert, validate, export) remain TODO/work-in-progress
  • Dashboard port changed: 3000 → 8787 (to avoid common port conflicts)
  • Application name: "Symphony" for branding, sym for commands

🎯 Next Steps (Future Work)

  1. Implement convert command (A → B schema conversion)
  2. Implement validate command (code validation)
  3. Implement export command (context-based convention extraction)
  4. Fix failing integration tests
  5. Add comprehensive documentation for validation features

🔍 Review Checklist

  • All commits have meaningful messages
  • No sensitive data in commits
  • Build succeeds (make build)
  • Tests pass (make test)
  • Documentation is up to date
  • Breaking changes are documented
  • Migration guide is clear

Ready to merge: All integration work complete, builds successfully, preserves all functionality from both projects.

📸 Screenshots

Dashboard

![Dashboard Screenshot Placeholder]
Web dashboard running on port 8787 with policy editor

CLI Commands

$ sym --help
Symphony (sym) - Code Convention Management Tool with RBAC

$ sym login
🎵 Symphony CLI 인증
...

$ sym dashboard
Starting dashboard server at http://localhost:8787

Branch: feat/integrate-symphony-client
Target: main
Commits: 18
Files Changed: ~50+
Lines Added/Deleted: +5000/-500 (approx)

baeyc0510 and others added 18 commits November 2, 2025 16:19
@claude
feat: extend UserPolicy schema for symphonyclient integration
140ea08 
Step 1: Schema Extension

Changes:
- Add CanEditPolicy and CanEditRoles to UserRole
  * Enables policy and role editing permission management
- Add No (rule number) and Example to UserRule
  * Supports rule ordering and example code display

All new fields are marked with 'symphonyclient integration' comments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
feat: copy symphonyclient packages to sym-cli
412e57e 
Step 2: File Copy

Copied directories:
- internal/auth/         (OAuth authentication)
- internal/config/       (configuration management)
- internal/git/          (git repository utilities)
- internal/github/       (GitHub API client)
- internal/roles/        (role management)
- internal/server/       (web dashboard server + static assets)
- scripts/               (build and install scripts)
- examples/              (example configurations)

Copied policy files:
- internal/policy/manager.go (renamed from policy.go)
- internal/policy/templates.go
- internal/policy/history.go
- internal/policy/templates/ (6 framework templates)

Next steps: Fix import paths and update configurations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
feat: add symphonyclient dependencies and build configuration
13d4e8e 
Step 3: Dependencies Setup

Changes:
- go.mod: Add github.com/pkg/browser for OAuth browser automation
- go.sum: Update dependency checksums
- package.json: Add Tailwind CSS build configuration
  * Updated name to sym-cli v2.0.0
  * CSS build scripts for dashboard
- tailwind.config.js: Tailwind CSS configuration

All changes marked with 'symphonyclient integration' comments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
refactor: update import paths from symphony to sym-cli module
11673e3 
Step 4: Import Path Fix

Changed all import statements in copied symphonyclient files:
- symphony/internal/* → github.com/DevSymphony/sym-cli/internal/*

Modified files:
- internal/auth/oauth.go
- internal/auth/server.go
- internal/config/config.go
- internal/git/repo.go
- internal/github/client.go
- internal/policy/manager.go
- internal/policy/templates.go
- internal/policy/history.go
- internal/roles/roles.go
- internal/server/server.go

Note: Configuration paths and error messages still reference 'symphony'
and will be updated in subsequent steps.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
refactor: change policy and roles paths from .github to .sym
efa9cf1 
Step 5: Path Migration (.github → .sym)

Changes:
- internal/policy/manager.go:
  * defaultPolicyPath: .github/user-policy.json → .sym/user-policy.json

- internal/roles/roles.go:
  * GetRolesPath: .github/roles.json → .sym/roles.json
  * Updated comments to reflect .sym directory
  * Changed directory creation from .github to .sym
  * Error message: 'symphony init' → 'sym init'

All changes marked with 'symphonyclient integration' comments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
refactor: change config directory from symphony to sym
289a7f1 
Step 6: Config Directory Migration

Changes in internal/config/config.go:
- configDir: ~/.config/symphony → ~/.config/sym
- Error messages: 'symphony config/login' → 'sym config/login'
- PolicyPath comment: .github → .sym default path
- All changes marked with 'symphonyclient integration' comments

User configuration will now be stored in:
- ~/.config/sym/config.json (OAuth settings)
- ~/.config/sym/token.json (access token)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
feat: integrate symphonyclient commands and change default port
40dba53 
Step 7 & 9: Command Integration and Port Change

Commands added to internal/cmd/:
- config.go    (OAuth configuration)
- login.go     (GitHub OAuth login)
- logout.go    (logout)
- init.go      (repository initialization)
- dashboard.go (web UI server)
- my_role.go   (role query)
- whoami.go    (user info)
- policy.go    (policy management)

Changes:
- Default dashboard port: 3000 → 8787
- OAuth callback port: 3000 → 8787
- All 'symphony' command references → 'sym'
- root.go: Updated to sym with unified description
- root.go: Registered all symphonyclient and sym-cli commands

All symphonyclient commands now work with 'sym' prefix.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
refactor: merge policy package with schema integration
5a455b9 
Step 8: Policy Package Merge

Changes in internal/policy/manager.go:
- Removed duplicate type definitions (Policy, RBAC, RBACRole, etc.)
- Use schema.UserPolicy, schema.UserRule types instead
- LoadPolicy returns *schema.UserPolicy
- SavePolicy accepts *schema.UserPolicy
- ValidatePolicy validates *schema.UserPolicy
- All changes marked with 'symphonyclient integration' comments

The policy package now uses unified schema types from pkg/schema:
- UserPolicy (A schema) for user input
- CodePolicy (B schema) for validation engine

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
feat: add CSS build targets to Makefile
8280761 
Step 11: Makefile Extension for Dashboard

Added CSS build targets:
- install-css: Install npm dependencies (Tailwind CSS)
- build-css: Build CSS from internal/server/static/styles
- watch-css: Watch and rebuild CSS on changes

Modified existing targets:
- build: Now runs build-css first
- build-all: Now runs build-css first
- clean: Now removes node_modules
- setup: Now runs install-css

All changes marked with 'symphonyclient integration' comments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
fix: resolve build errors and complete integration
0bf94d5 
Step 12: Build Fixes and Completion

Fixed type references throughout the codebase:
- internal/policy/templates.go: Policy → schema.UserPolicy
- internal/server/server.go: policy.Policy → schema.UserPolicy
- internal/cmd/init.go: All policy types → schema types
- cmd/sym/main.go: Removed unused os import, fixed Execute() call

Build result:
- Successfully compiled bin/sym.exe (11MB)
- All symphonyclient and sym-cli features integrated
- Ready for testing and deployment

All changes marked with 'symphonyclient integration' comments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
fix: update environment variables and paths for consistency
abfb154 
Consistency fixes for symphonyclient integration:
- Environment variables: SYMPHONY_* → SYM_*
  * SYM_AUTH_MODE (config.go)
  * SYM_SERVER_URL (config.go)
- Help text: .github → .sym
  * init.go: command description and usage examples
  * policy.go: default path display
- Default policy DenyWrite: .github/** → .sym/**

All references now use unified 'sym' naming convention.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
refactor: update tool directories from .symphony to .sym
1645f7d 
Consistency improvements for symphonyclient integration:
- Tool directories: ~/.symphony/tools → ~/.sym/tools
- Cache directory: ~/.symphony/cache → ~/.sym/cache
- Updated comments in adapters and engine core
- Updated AuthenticateWithServer comment (Sym auth server)

Note: Application name "Symphony" remains in user-facing messages,
only command/directory names use "sym" abbreviation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
fix: add .exe extension for Windows builds in Makefile
012ff26 
- Detect Windows platform using OS environment variable
- Automatically append .exe extension on Windows
- Keep Unix-style binary name on Linux/macOS

This ensures Windows users get sym.exe instead of sym.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
style: unify rule category indicator colors to gray
b9110e0 
Changed all category indicator colors from distinct colors
(blue, purple, amber, red, etc.) to uniform gray (border-gray-400).

Before:
- naming: blue
- formatting: purple
- error_handling: amber
- security: red
- testing: teal
- documentation: green
- etc.

After:
- All categories: gray-400

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
feat: implement auto-save functionality for dashboard
62840f1 
Added complete auto-save feature with the following capabilities:

Features:
- Auto-save timer: saves every 30 seconds when enabled
- Only saves when there are unsaved changes (isDirty)
- Bypasses confirmation dialog for auto-save
- Shows info toast when auto-saved
- Persists settings to localStorage
- Restores settings on page load

Implementation:
- setInterval timer checks autoSave flag and isDirty state
- Temporarily disables confirmSave during auto-save
- Added event listeners for checkbox changes
- Settings saved to localStorage immediately on change
- Toast notification shows auto-save status

User Experience:
- Toggle auto-save checkbox to enable/disable
- Settings persist across browser sessions
- Visual feedback via toast notifications
- No interruption from confirmation dialogs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
fix: update placeholder from .github to .sym in policy path input
d56161d 
Changed policy path input placeholder to reflect new directory:
- Before: .github/user-policy.json
- After: .sym/user-policy.json

This aligns with the directory change made during symphonyclient
integration where all policy files moved from .github/ to .sym/

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
docs: update README and gitignore for integrated project
8339a0c 
Changes:
1. .gitignore updates:
   - Added .sym/ (policy and roles directory)
   - Added coverage.html
   - Added node_modules/

2. README.md complete rewrite:
   - Merged sym-cli and symphonyclient features
   - Updated all paths: .github → .sym
   - Added dashboard documentation (port 8787)
   - Added auto-save feature documentation
   - Included RBAC and policy editor features
   - Updated project structure
   - Added quick start guide
   - Added usage examples
   - Noted that convert/validate/export are work in progress

The README now accurately reflects the integrated system
combining role management, policy editing, and code validation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
chore: add package-lock.json and update output.css
81889f0 
- Add package-lock.json for reproducible builds
  * Locks Tailwind CSS version for all developers
  * Ensures consistent dependency resolution

- Update output.css (Tailwind build output)
  * Generated from latest changes
  * Embedded in binary via go:embed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
ikjeong
ikjeong approved these changes Nov 2, 2025 •
edited
Loading
View reviewed changes
@sehwan505 sehwan505 merged commit 802613d into main Nov 3, 2025
@sehwan505 sehwan505 deleted the feat/integrate-symphony-client branch December 10, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikjeong ikjeong ikjeong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baeyc0510 @ikjeong @sehwan505