Add TypeScript type checker and enhance validation engine infrastructure#4
Merged
Add TypeScript type checker and enhance validation engine infrastructure#4
Conversation
- Move testdata from tests/ to project root - Rename integration tests for consistency (_integration_test.go) - Add helper utilities for integration tests - Add basic workflow E2E test script - Reorganize JavaScript test fixtures - Add mixed language test fixtures (JSX/TSX)
- Implement TypeScript compiler (tsc) adapter - Add type checker validation engine - Support strict mode and type error detection - Add comprehensive test coverage - Register type checker in builtin engines
- Add ESLint adapter tests (adapter, config, executor) - Add Prettier adapter tests (adapter, executor) - Improve test coverage for external tool adapters
- Add core selector utility for rule filtering - Improve AST engine with better error handling - Enhance length, pattern, and style engines - Remove deprecated autofix.go - Add comprehensive engine tests
- Remove old integration test files (moved to *_integration_test.go) - Remove old testdata location (moved to project root) - Add missing E2E test script to git tracking
- Add verbose global flag to root.go for convert and validate commands - Remove exportCmd reference (export command not yet implemented) - Add mcpCmd to root command list - Remove duplicate AddCommand calls from convert.go and validate.go init() - Add missing doublestar/v4 dependency to go.mod This allows the engine improvements branch to build successfully. The export command will be implemented in a future update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
검증 엔진 인프라 강화 및 TypeScript 타입 체커 엔진 추가
What's Changed
1. TypeScript Type Checker Engine
internal/engine/typechecker/- TSC 기반 타입 검증internal/adapter/tsc/- TypeScript Compiler 래퍼2. Core Selector Utility
internal/engine/core/selector.go- 파일 필터링 공통 함수**/*.js)3. Comprehensive Adapter Tests (+882 lines)
4. Engine Improvements
5. Test Structure Reorganization
tests/testdata/→testdata/(루트 이동)*_test.go→*_integration_test.go(명확한 구분)6. Build Fixes
verbose전역 플래그 추가exportCmd참조 제거doublestar/v4의존성 추가Next Steps
이 PR은 검증 엔진 인프라를 완성합니다. 다음 작업이 필요합니다:
1. Validator 구현 (최우선, ~100줄)
2. Converter 구현 (~300줄)
3. 실전 테스트
Checklist
Note
중요: 엔진과 어댑터는 모두 작동하지만,
validator.Validate()가 아직 엔진을 호출하지 않습니다. 다음 PR에서 validator 구현 시 전체 시스템 작동 예정.