Skip to content

Feature: GitHub OAuth Sign up / Sign in (parity with Google OAuth)#184

Merged
Annanyatiwary4 merged 3 commits intoDevSyncx:mainfrom
prayagupa23:main
Oct 15, 2025
Merged

Feature: GitHub OAuth Sign up / Sign in (parity with Google OAuth)#184
Annanyatiwary4 merged 3 commits intoDevSyncx:mainfrom
prayagupa23:main

Conversation

@prayagupa23
Copy link
Contributor

🚀 Pull Request Checklist
[x] ✅ My issue is assigned to me, and I have not taken up another task simultaneously.
[x] 🔁 I have pulled the latest changes from the main branch.
[x] 🧪 My code is tested and does not break existing functionality.
[ ] 📚 I have added/updated documentation wherever necessary.
[x] 🧹 My code follows the project’s coding standards.
[x] ✍️ My commits are clear and meaningful.
[x] 🧾 I have linked the issue this PR addresses with Closes #<issue_number>.


📌 Related Issue
Closes #41


🧠 Description
Adds GitHub OAuth authentication alongside the existing Google flow. Authenticated users are issued a JWT on successful GitHub login/signup and are redirected to /dashboard?token=..., where the token is stored for subsequent API calls. Includes a first-time signup fix to ensure the dashboard does not bounce to Login on the initial redirect.

✅ Type of Change
[ ] 🐞 Bug fix
[x] 💡 Feature
[ ] 🧹 Code cleanup/refactor
[ ] 🧪 Test cases
[ ] 📚 Docs update


📝 Additional Notes (Optional)

  • Backend env required: GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET, GITHUB_CALLBACK_URL, CLIENT_URL, JWT_SECRET, MONGO_URI.
  • Frontend env: VITE_API_URL.
  • Non‑breaking changes; Google and email/password auth unaffected.

@Annanyatiwary4

@vercel
Copy link

vercel bot commented Oct 15, 2025

@prayagupa23 is attempting to deploy a commit to the Annanya's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

🙌 Thanks @prayagupa23 for raising this PR!
Our team will review it soon ⏳ — meanwhile, please make sure your PR follows our contributing guidelines 👉 Contributing Guidelines 🎉

@Annanyatiwary4 Annanyatiwary4 merged commit dcb1775 into DevSyncx:main Oct 15, 2025
1 check failed
@github-actions
Copy link

🎉🎉 Thank you for your contribution! Your PR #184 has been merged! 🎉🎉

@Annanyatiwary4 Annanyatiwary4 added gssoc25 Only for Gssoc 25 contributors Frontend backend hacktoberfest-accepted only for hacktoberfest 2025 candidate labels Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Frontend gssoc25 Only for Gssoc 25 contributors hacktoberfest-accepted only for hacktoberfest 2025 candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Sign Up using Github

2 participants

Comments