Added caching to boost performance with long lists#2
Merged
jackcompton merged 2 commits intoDevTech-ADVISE:masterfrom Feb 4, 2015
AlwaysMoreHats:master
Merged
Added caching to boost performance with long lists#2jackcompton merged 2 commits intoDevTech-ADVISE:masterfrom AlwaysMoreHats:master
jackcompton merged 2 commits intoDevTech-ADVISE:masterfrom
AlwaysMoreHats:master
Conversation
The menus are now cached, and build menu will not recreate its menu if only the focussed item has changed (but will if the filtered items change)
The focus changes didn’t check to make sure both items were in the list (despite the fact that it shouldn’t happen). Now it does check.
jackcompton
added a commit
that referenced
this pull request
Feb 4, 2015
Added caching to boost performance with long lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menus are now cached, and build menu will not recreate its menu if
only the focussed item has changed (but will if the filtered items
change)