Skip to content

fix: enable code quality workflow on pull requests#36

Merged
iqbalhasandev merged 2 commits intomainfrom
fix/workflow-pr-trigger
Apr 12, 2026
Merged

fix: enable code quality workflow on pull requests#36
iqbalhasandev merged 2 commits intomainfrom
fix/workflow-pr-trigger

Conversation

@iqbalhasandev
Copy link
Copy Markdown
Member

Summary

  • Uncomment the pull_request trigger in code-quality.yml so ESLint and format checks run on every PR
  • The auto-format and auto-commit steps are already gated on push events only, so they won't attempt to commit on PRs

Test plan

  • Verify the Code Quality workflow appears as a check on this PR
  • Verify ESLint passes

Copilot AI review requested due to automatic review settings April 12, 2026 04:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the existing Code Quality GitHub Actions workflow to run on pull requests so ESLint and formatting checks execute during PR review, not only after pushes to main/develop.

Changes:

  • Enable the pull_request trigger for the code-quality workflow on main and develop.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Set workflow-level permissions to contents: read (least-privilege for PR runs)
- Split auto-format/commit into a separate job gated to push only, with
  job-level contents: write
- Remove ref: github.head_ref from checkout (broken on push events and fork PRs)
- Add prettier --check step to quality-check job so formatting is validated on PRs
@iqbalhasandev iqbalhasandev merged commit 330e894 into main Apr 12, 2026
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants