Skip to content

fix: resolve npm peer dependency conflict blocking CI #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iqbalhasandev merged 1 commit into from
Apr 12, 2026
Merged

fix: resolve npm peer dependency conflict blocking CI #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment explaining why legacy-peer-deps is enabled (e.g., unbuild@3.6.1 ↔ TypeScript 6 peer conflict) and when it can be removed. Without context, this setting can be confusing for future maintainers.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting legacy-peer-deps=true in a repo-level .npmrc affects all installs (local dev, CI, and any scripts) and can mask new peer dependency issues. Consider scoping this to CI only (e.g., npm ci --legacy-peer-deps or NPM_CONFIG_LEGACY_PEER_DEPS=true in workflows) to keep stricter resolution for developers while still unblocking CI.

Suggested change
legacy-peer-deps=true

Copilot uses AI. Check for mistakes.