Skip to content

Add formal repository structure and 30+ new files#2

Merged
Devanik21 merged 9 commits intomainfrom
jules-13368987183974811300-e14979ea
Apr 19, 2026
Merged

Add formal repository structure and 30+ new files#2
Devanik21 merged 9 commits intomainfrom
jules-13368987183974811300-e14979ea

Conversation

@Devanik21
Copy link
Copy Markdown
Owner

Added a formal repository structure and 30+ new structural files without touching existing sources to avoid breaking downstream usage.


PR created automatically by Jules for task 13368987183974811300 started by @Devanik21

Added new directory structures (src, tests, docs, data, config, etc) and over 30
formal files focusing on the repository's main domain (State Space Models, Mamba, S4, Loihi 2 specs, etc)
to enhance the structural integrity of the project without touching the existing files.

Co-authored-by: Devanik21 <162272415+Devanik21@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Aether-SPARC v3 framework, an asynchronous event-triggered signal processor featuring core algorithms like Adaptive Level-Crossing Sampling (ALCS), model implementations for Mamba and S4, and hardware mapping for Intel Loihi 2. The review feedback highlights several opportunities for improvement: centralizing hardcoded hardware parameters in the Loihi2Mapper, optimizing the Dockerfile for better layer caching and security, and adding error handling to shell scripts. Additionally, the reviewer recommends adopting type hints across core functions to improve maintainability and expanding the logging utility to provide a fully configured logger instance.

Comment thread src/models/loihi.py Outdated
Comment thread Dockerfile
Comment on lines +3 to +4
COPY . .
RUN pip install -r requirements.txt
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current order of COPY and RUN commands is inefficient for Docker layer caching. Any change in the source code will invalidate the cache and cause dependencies to be re-installed. Also, COPY . . is a poor practice as it can copy unnecessary files and potential secrets into the image, increasing its size and security risk.

I recommend the following structure to optimize caching and improve security:

# Copy only the requirements file first
COPY requirements.txt .

# Install dependencies
RUN pip install -r requirements.txt

# Then copy the application code
COPY src ./src
COPY config ./config

You should also consider adding a .dockerignore file to explicitly exclude files not needed in the image.

Comment thread scripts/deploy_loihi.sh Outdated
Comment thread scripts/evaluate.sh Outdated
Comment thread scripts/train.sh Outdated
Comment thread src/core/event_trigger.py Outdated
Comment thread src/core/predictive_coding.py Outdated
Comment thread src/data/transforms.py Outdated
Comment thread src/utils/logger.py
@@ -0,0 +1,3 @@
"""Experiment logging utilities."""

import logging
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file only imports the logging module. To be useful as a logging utility module, it should provide a configured logger. Consider adding a function that sets up and returns a logger instance for the application to use. This centralizes logging configuration.

For example:

import logging
import sys

def get_logger(name: str) -> logging.Logger:
    logger = logging.getLogger(name)
    logger.setLevel(logging.INFO)
    handler = logging.StreamHandler(sys.stdout)
    formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s')
    handler.setFormatter(formatter)
    logger.addHandler(handler)
    return logger

Comment thread src/utils/metrics.py Outdated
Devanik21 and others added 8 commits April 19, 2026 18:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Devanik21 Devanik21 merged commit 25afb1a into main Apr 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant