-
Notifications
You must be signed in to change notification settings - Fork 1
feat: 홈 페이지에서 유저 정보를 가져와 카드 내용을 구성하도록 구현 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { doc, getDoc } from 'firebase/firestore'; | ||
| import { db } from '../firebase'; | ||
|
|
||
| // 프로필 데이터 타입 | ||
| export interface Profile { | ||
| nickname: string; | ||
| email: string; | ||
| streakDays: number; | ||
| tilCount: number; | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| // 1. 유저 프로필 정보 가져오기 | ||
| export const getProfile = async (uid: string): Promise<Profile | null> => { | ||
| const userDocRef = doc(db, 'users', uid); | ||
| const docSnap = await getDoc(userDocRef); | ||
|
|
||
| if (docSnap.exists()) { | ||
| return docSnap.data() as Profile; | ||
| } else return null; | ||
| }; | ||
|
|
||
| // 2. 사용자 프로필 정보 업데이트 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getProfile 호출 시 에러 처리 누락
loadTodos함수는 내부적으로 try/catch로 에러를 처리하지만,getProfile호출은 에러 처리가 없습니다. Firestore 요청 실패 시 unhandled promise rejection이 발생할 수 있습니다.🛠️ 에러 처리 추가 제안
useEffect(() => { if (currentUser) { const loadData = async () => { - const userProfile = await getProfile(currentUser.uid); - setProfile(userProfile); - - await loadTodos(currentUser.uid); + try { + const userProfile = await getProfile(currentUser.uid); + setProfile(userProfile); + await loadTodos(currentUser.uid); + } catch (err) { + console.error(err); + setError('프로필 정보를 불러오는 데 실패하였습니다'); + } }; loadData(); } else { setTodos([]); setProfile(null); } }, [currentUser]);🤖 Prompt for AI Agents