feat: add shellcheck linting for shell scripts in CI#66
Merged
Conversation
Added shellcheck linting to improve code quality and catch potential issues in shell scripts. This includes: - New 'check-shellcheck' target in Makefile to run shellcheck on all shell scripts - New 'shellcheck' job in CI workflow that runs on both AMD64 and ARM64 runners - Lints all shell scripts in ci/ and rust/ci/ directories
Updated shell script checking to match the naming conventions and structure used in the rust directory: - Renamed check-shellcheck to check-shell-linting for consistency - Added check-shell-formatting and fix-shell-formatting using shfmt - Restructured CI workflow to use formatting/linting jobs with language matrix - Follows the same pattern as rust/.github/workflows/continuous-integration.yml
Updated CI workflow to use Nix for tool installation instead of apt-get: - Added Setup Nix step to formatting and linting jobs - Use 'nix develop -c make' instead of direct 'make' commands - Added shfmt and shellcheck to flake.nix buildInputs - Matches the approach used in rust/.github/workflows/continuous-integration.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added shellcheck linting to improve code quality and catch potential issues in shell scripts. This includes: