[#117] | Dhanoj | Enhance the styling of request completion time#165
Conversation
| expect(navbar).toBeInTheDocument(); | ||
| expect(statusBar).toHaveTextContent(/^200 OK 0.12s$/); | ||
| expect(statusBar).toHaveTextContent(/^200 OK0.12s$/); | ||
| }); |
There was a problem hiding this comment.
Is that expected not to have a single space between the status text and time taken? or is it just a lint fix?
| expect(navbar).toBeInTheDocument(); | ||
| expect(statusBar).toHaveTextContent(/^Network Error 0.46s$/); | ||
| expect(statusBar).toHaveTextContent(/^Network Error0.46s$/); | ||
| }); |
There was a problem hiding this comment.
Here as well, Shouldn't the space is expected
Aman-shabbas
left a comment
Aman-shabbas
left a comment
There was a problem hiding this comment.
Hi @Dhanoj0810 I've added comments about few doubts I had during the Review, once you clarify that I can approve this
|
We're using CSS gap: 12px for visual spacing only, not adding any space character in the JSX. The tests needed to be updated to match the actual DOM text content, which doesn't include the visual spacing created by CSS gap. The visual spacing works perfectly for the UI, but the DOM text content remains '200 OK0.12s' without any space character. I've updated the ResponsePanel test cases to resolve confusion about the spacing implementation. |
…in ResponsePanel tests
Aman-shabbas
left a comment
Aman-shabbas
left a comment
There was a problem hiding this comment.
Changes verified and approved
3 participants
Uh oh!
There was an error while loading. Please reload this page.