[#126] | Binni | Add header count badge to response panel#177
Merged
kannananil merged 3 commits intoOct 23, 2025
Conversation
2 tasks
kannananil
reviewed
Oct 22, 2025
Collaborator
kannananil
left a comment
kannananil
left a comment
There was a problem hiding this comment.
Hi @droidbg, thank you very much for your efforts and the changes looks good and clean, you have covered all the aspects and added the tests covering new source code changes as well.
I have added a couple of comments regarding some logics, those are just refactoring thoughts, not a blocker but go through them and share your thoughts. We can proceed with merging this PR according to that.
…ead of undefined and simplify condition checks
Contributor
Author
|
Hi @kannananil, i have fixed both the comments in the latest commit, could you pls verify the changes again, Thanks. |
kannananil
approved these changes
Oct 23, 2025
Collaborator
kannananil
left a comment
kannananil
left a comment
There was a problem hiding this comment.
@droidbg, the changes looks good, we can proceed to merge. Once again thanks for your efforts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Headers Count as part of the issue #126
📸 Screenshots
Before:
After:
Closes : #126