Reduce ROM usage of music module#529
Merged
hexfet merged 2 commits intoDeviationTX:masterfrom Jan 3, 2019
Merged
Conversation
Contributor
howard0su
commented
Jan 2, 2019
howard0su
commented
- Parse the name of tone instead of a table.
- Only store one scale of freq and caculate others.
1. Parse the name of tone instead of a table. 2. Only store one scale of freq and caculate others.
Contributor
Author
|
Don't know how to test this. The ROM size saving is noticable: Before: After: |
howard0su
changed the title
Contributor
TheRealMoeder
left a comment
TheRealMoeder
left a comment
There was a problem hiding this comment.
Reads good, will have to test on real TX to approve
Contributor
Author
|
verified on 7e, at least startup music works fine. |
Contributor
Author
|
maybe we should have a longer music for startup. it is fine to compose music like that. |
Contributor
Every user is open to do so. Feel free to compose a deviation theme if you wish ;-) |
goebish
approved these changes
Jan 3, 2019
hexfet
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.