Fix calibration (issue #574)#582
Merged
hexfet merged 1 commit intoDeviationTX:masterfrom Jan 14, 2019
Merged
Conversation
…es channel data is updated for functions like calibration.
goebish
approved these changes
Jan 13, 2019
howard0su
reviewed
Jan 13, 2019
| CLOCK_StopTimer(); | ||
| if(Model.protocol != PROTOCOL_NONE && PROTOCOL_LOADED) | ||
| PROTO_Cmds(PROTOCMD_DEINIT); | ||
| CLOCK_StartMixer(); // run mixer on timer so channels are updated for things like calibration |
Contributor
There was a problem hiding this comment.
I prefer putting the comments above the line, which is more common practice and also make the width of line small.
Contributor
There was a problem hiding this comment.
I actually prefer this way because it makes it more likely the comment will be preserved if the line is moved. But it isn't a strong rule
howard0su
approved these changes
Jan 13, 2019
PhracturedBlue
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run mixer calculations on timer after de-initializing protocol. Ensures channel data is updated for functions like calibration. Fixes #574 .