Skip to content

Fixup TypeScript error for test #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koral-- merged 1 commit into from
Apr 6, 2022
Merged

Fixup TypeScript error for test #269

koral-- merged 1 commit into from
Apr 6, 2022

Conversation

@jonathanKingston
Copy link

@jonathanKingston jonathanKingston commented Apr 6, 2022 •
edited
Loading

One of the tests is failing in CI:

test/mock/duplex.ts:26:5 - error TS2416: Property 'end' in type 'MockDuplex' is not assignable to the same property in base type 'Duplex'.

This is breaking all the dependabot upgrades, namely #268 which includes a security fix.

@jonathanKingston
Fixup TypeScript error for test
d0ef9fb 
Signed-off-by: Jonathan Kingston <jkingston@duckduckgo.com>
@koral-- koral-- merged commit cf948a0 into DeviceFarmer:master Apr 6, 2022
@koral--
Copy link
Member

koral-- commented Apr 6, 2022

Thanks

@jonathanKingston jonathanKingston deleted the fixup-test branch April 6, 2022 12:52
@renovate renovate bot mentioned this pull request Apr 20, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koral-- koral-- koral-- approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanKingston @koral--