Fix adb disconnect always throwing an error #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koral--
approved these changes
Jun 4, 2022
Member
koral--
left a comment
koral--
left a comment
There was a problem hiding this comment.
LGTM but please add a sign-off.
"disconnected IP" is a possible value for successfull adb disconnects. See Android 11 source: https://cs.android.com/android/platform/superproject/+/android-11.0.0_r48:system/core/adb/adb.cpp;l=1224 Signed-off-by: Wolfgang Haupt <haupt.wolfgang@gmail.com>
a1rwulf
force-pushed
the
adb-connection-fixes
branch
from
b36c50f to
9d1a4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix an exception on disconnect, although it successfully disconnects.
The reason is that "disconnected IP" is a possible value for successfull adb disconnects at least on Android11.
See Android 11 source:
https://cs.android.com/android/platform/superproject/+/android-11.0.0_r48:system/core/adb/adb.cpp;l=1224
Tested with an Nvidia Shield with Shield Experience 9.0.2 which is Android 11.