feat(profile): make edit profile icon navigate to account settings page#114
Open
Javenn0 wants to merge 2 commits into
Open
feat(profile): make edit profile icon navigate to account settings page#114Javenn0 wants to merge 2 commits into
Javenn0 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Profile page’s “Edit profile” (pencil) icon so it actually navigates users to the workspace account settings screen, matching the intended UX for “your work”.
Changes:
- Replaced the non-functional edit
<button>with areact-router-dom<Link>. - Wired the icon to navigate to
/{workspaceSlug}/settings/account.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…x-edit-button-in-your-work
KaEunice
approved these changes
May 12, 2026
Rafetikus
approved these changes
May 12, 2026
nazarli-shabnam
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #76
This pull request updates the profile editing UI on the
ProfilePage. The main change is replacing the edit profile button with a link that navigates directly to the account settings page, improving navigation and accessibility.UI and navigation improvements:
<button>with a<Link>that routes users to the account settings page (/settings/account), making the edit action more intuitive and accessible. (ui/src/pages/ProfilePage.tsx) [1] [2]