Skip to content

Refactor: removed book icon#88

Merged
Javenn0 merged 2 commits into
mainfrom
84-remove-the-useless-book-icon
Apr 15, 2026
Merged

Refactor: removed book icon#88
Javenn0 merged 2 commits into
mainfrom
84-remove-the-useless-book-icon

Conversation

@Javenn0
Copy link
Copy Markdown
Member

@Javenn0 Javenn0 commented Apr 15, 2026

This pull request removes the settings button and its associated icon from the sidebar in Sidebar.tsx. The IconBook component and the corresponding Link to the settings page are no longer present.

UI cleanup:

  • Removed the IconBook component definition from Sidebar.tsx, eliminating the SVG icon previously used for the settings button.
  • Removed the settings Link (which used the IconBook icon) from the sidebar, so users will no longer see or be able to navigate to settings from the sidebar.
    closes Remove the useless book icon #84

Copilot AI review requested due to automatic review settings April 15, 2026 05:00
@Javenn0 Javenn0 linked an issue Apr 15, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the “book” icon from the UI sidebar footer to address Issue #84 (“Remove the useless book icon”) and simplify the sidebar footer actions.

Changes:

  • Deleted the IconBook SVG component from Sidebar.tsx.
  • Removed the footer “Settings” link that was rendered using the book icon.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui/src/components/layout/Sidebar.tsx Outdated
@nazarli-shabnam nazarli-shabnam added the good first issue Good for newcomers label Apr 15, 2026
@nazarli-shabnam nazarli-shabnam added this to the Deadline milestone Apr 15, 2026
@nazarli-shabnam nazarli-shabnam changed the title Removed book icon Refactor: removed book icon Apr 15, 2026
Copy link
Copy Markdown
Member

@nazarli-shabnam nazarli-shabnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldnt lead to settings page. the button is for open-close sidebar.

@Javenn0
Copy link
Copy Markdown
Member Author

Javenn0 commented Apr 15, 2026

it shouldnt lead to settings page. the button is for open-close sidebar.

Done

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui/src/components/layout/Sidebar.tsx
Copy link
Copy Markdown
Member

@martian56 martian56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well fixed!

Copy link
Copy Markdown
Member

@nazarli-shabnam nazarli-shabnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

Copy link
Copy Markdown
Member

@Rafetikus Rafetikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Javenn0 Javenn0 merged commit 3fce74b into main Apr 15, 2026
11 checks passed
@martian56 martian56 deleted the 84-remove-the-useless-book-icon branch May 2, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the useless book icon

5 participants