48 implement cycle details page#97
Merged
Merged
Conversation
nazarli-shabnam
added
bug
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a new Cycle details page in the UI and wires up navigation so users can open a cycle from the cycles list and from favorites.
Changes:
- Added a new
CycleDetailPageroute under project cycles. - Updated cycle links (cycles list + sidebar favorites) to use a name-based path segment helper.
- Made cycle rows clickable to navigate to the new details page.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/routes/index.tsx | Adds lazy-loaded route for the new cycle details page. |
| ui/src/pages/CyclesPage.tsx | Updates cycle URL generation and adds row click/keyboard navigation. |
| ui/src/pages/CycleDetailPage.tsx | New page that loads cycle + work items and renders a details table. |
| ui/src/lib/cycle.ts | Introduces helpers for cycle URL segment generation and matching. |
| ui/src/components/layout/Sidebar.tsx | Updates favorite cycle links to use the new cycle URL segment helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+713
to
+721
| role="button" | ||
| tabIndex={0} | ||
| onClick={() => navigate(path)} | ||
| onKeyDown={(e) => { | ||
| if (e.key === 'Enter' || e.key === ' ') { | ||
| e.preventDefault(); | ||
| navigate(path); | ||
| } | ||
| }} |
Comment on lines
+4
to
+15
| export function cyclePathSegment(cycle: Pick<CycleApiResponse, 'name'>): string { | ||
| const s = slugify(cycle.name); | ||
| return s || 'cycle'; | ||
| } | ||
|
|
||
| export function cycleMatchesPathSegment( | ||
| cycle: Pick<CycleApiResponse, 'id' | 'name'>, | ||
| segment: string, | ||
| ): boolean { | ||
| const key = segment.trim().toLowerCase(); | ||
| if (!key) return false; | ||
| return cycle.id.toLowerCase() === key || cyclePathSegment(cycle) === key; |
Comment on lines
1191
to
1194
| <Link | ||
| key={`${projectId}:${cycle.id}`} | ||
| to={`${baseUrl}/projects/${projectId}/cycles/${cycle.id}`} | ||
| to={`${baseUrl}/projects/${projectId}/cycles/${cyclePathSegment(cycle)}`} | ||
| className="flex w-full items-center gap-2 rounded-(--radius-md) px-2 py-1.5 text-[13px] font-medium text-(--txt-secondary) hover:bg-(--bg-layer-transparent-hover) hover:text-(--txt-primary)" |
Comment on lines
+56
to
+61
| Promise.all([ | ||
| workspaceService.getBySlug(workspaceSlug), | ||
| projectService.get(workspaceSlug, projectId), | ||
| cycleService.list(workspaceSlug, projectId), | ||
| issueService.list(workspaceSlug, projectId, { limit: 500 }), | ||
| stateService.list(workspaceSlug, projectId), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #48