Skip to content

chore: enable try_err clippy lint #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
Merged

chore: enable try_err clippy lint #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38fd86e
chore: enable `try_err` clippy lint
RRRadicalEdward Oct 2, 2025
607603e
fix warnings on Windows
RRRadicalEdward Oct 2, 2025
ce127fb
Merge branch 'master' into enable-try_err-clippy-lint
RRRadicalEdward Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ range_plus_one = "warn"
# TODO: self_named_module_files = "warn"
# TODO: partial_pub_fields = "warn" (should we enable only in pdu crates?)
redundant_type_annotations = "warn"
try_err = "warn"
rest_pat_in_fully_bound_structs = "warn"

# == Compile-time / optimization == #
Expand Down
4 changes: 2 additions & 2 deletions crates/ironrdp-cliprdr-native/src/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ impl WinClipboard {
// SAFETY: low-level WinAPI call
let atom = unsafe { RegisterClassA(&wc) };
if atom == 0 {
return Err(Error::from_win32())?;
return Err(WinCliprdrError::from(Error::from_win32()));
}

// SAFETY: low-level WinAPI call
Expand All @@ -184,7 +184,7 @@ impl WinClipboard {
};

if window.is_invalid() {
return Err(Error::from_win32())?;
return Err(WinCliprdrError::from(Error::from_win32()));
}
// Init clipboard processing for WinAPI event loop
//
Expand Down
Loading