fix(client): address PR #1115 review feedback#1127
Draft
Conversation
…it logging, move tests Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve .rdp merge support and startup sizing
fix(client): address PR #1115 review feedback
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies review feedback on #1115 — the
.rdpmerge/startup sizing PR.Changes
xtask/src/cov.rs: Revert--no-cfg-coverageadditions (unintended change)rdp.rs:295: Restoredebug!(?connection_result)— the PR had replaced it with a plain string, losing structured debug output of the connection resultconfig.rs: Remove alldebug!calls fromConfig::parse_from()and its helpers — the logger is not initialized at parse time (parse_fromruns beforesetup_logging()inmain()), making every call a silent no-op. Also removes the now-unnecessarySUPPORTED_RDP_PROPERTIES,SENSITIVE_RDP_PROPERTIES,redacted_rdp_line, and related helpers that existed solely for this dead logging. Simplifies helper signatures (rdp_u16_property,rdp_u32_property) and audiomode/KDC proxy handling.Tests: Move
ironrdp-client/tests/config_rdp_merge.rs→ironrdp-testsuite-extra/tests/rdp_client_config.rs_mergesuffixTempRdpFile(Drop-based cleanup, safe on panic)desktopwidth/desktopheight/desktopscalefactor) including out-of-range fallback behavioruuidfromironrdp-clientregular deps (was only used by the test)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.