refactor(async,blocking)!: make Framed::read_exact crate-private

[Greg Lamberson (glamberson)]

Summary

Closes #1226.

Framed holds an invariant that buf starts at the first byte of a PDU message. read_pdu and read_by_hint maintain that invariant. Framed::read_exact also maintains it for its own callers, but exposing it as pub lets external callers leave buf misaligned by passing an arbitrary length, which then breaks subsequent read_pdu calls.

Both ironrdp_async::framed::Framed and ironrdp_blocking::framed::Framed have the same shape and the same exposure. Audit shows no external consumers across the workspace; the four call sites are all internal:

Crate	Call site
ironrdp-async	framed.rs:145 (read_pdu)
ironrdp-async	framed.rs:174 (read_by_hint)
ironrdp-blocking	framed.rs:74 (read_pdu)
ironrdp-blocking	framed.rs:96 (read_by_hint)

Both visibility changes use pub(crate).

Also drops the #[expect(clippy::missing_panics_doc)] annotation that was placed on the inline expect("length > self.buf.len()") because the lint only fires on public APIs; with the methods now pub(crate), the expectation is unfulfilled and clippy fails the build.

Breaking change

Marked with ! in the conventional commit. Affects any out-of-workspace consumer that called Framed::read_exact directly. The audit was workspace-only; if someone has a private consumer that relied on this, the migration is to use read_pdu (when reading a structured PDU) or read_by_hint (when the length comes from a header peek) — both maintain the buffer invariant correctly.

Pre-1.0 (ironrdp-async 0.8, ironrdp-blocking 0.8); per Cargo SemVer a 0.8 → 0.9 minor bump covers this.

Test plan

• cargo xtask check fmt -v clean
• cargo xtask check lints -v clean
• cargo xtask check tests -v passes
• cargo build --workspace --all-targets clean

[Greg Lamberson (glamberson)]

copilot-pull-request-reviewer please review

[Benoît Cortier (CBenoit)]

Easy win!

[Copilot]

Pull request overview

Restricts Framed::read_exact to crate-private visibility in both ironrdp-async and ironrdp-blocking to protect the internal buffer alignment invariant maintained by read_pdu/read_by_hint. Also removes now-unfulfilled #[expect(clippy::missing_panics_doc)] annotations since the lint no longer fires on non-public methods.

Changes:

• Change pub fn read_exact to pub(crate) fn read_exact in ironrdp-async and ironrdp-blocking.
• Remove #[expect(clippy::missing_panics_doc, ...)] annotations that would otherwise become unfulfilled expectations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/ironrdp-async/src/framed.rs	Restrict async read_exact visibility and drop unfulfilled clippy expectation.
crates/ironrdp-blocking/src/framed.rs	Restrict blocking read_exact visibility and drop unfulfilled clippy expectation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.