chore(release): apply release-prep skill pass — fix version bumps and changelogs#1286
Closed
Copilot wants to merge 4 commits into
Closed
chore(release): apply release-prep skill pass — fix version bumps and changelogs#1286Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Chore: prepare for publishing
chore: attempt release-prep skill invocation for release PR
May 19, 2026
Adds .github/skills/release-prep/SKILL.md, a project-local skill that guides the GitHub Copilot agent through the human-in-the-loop pass on release-plz "chore(release): prepare for publishing" PRs: - public-dependency propagation rule (public marker semantics, with the asymmetry that patch bumps don't propagate because Cargo.toml requirements are major.minor only) - per-crate changelog rewrite policy for cross-crate commits - deduplication of commits that collapse into a single net change within the release window (reverts, iterations on unreleased features, mechanical follow-ups) - scope-of-edits guard (CHANGELOG.md and Cargo.toml only on the PR branch; source/README/MSRV changes go to main and regenerate) - procedure anchored on `git diff origin/main` against the checked-out branch, with the correct lockfile flow (regenerate without --locked, commit, then `cargo xtask check locks -v`)
Member
|
Copilot I commited the skill in this branch, try to invoke it again |
Apply the public-dependency propagation rule: breaking changes in a #public dependency require a minor bump in the depending crate (pre-1.0). The following crates had breaking changes in public dependencies that were incorrectly proposed as patch bumps. Corrected to minor bumps: - ironrdp-svc: 0.6.1 → 0.7.0 (ironrdp-pdu 0.8 is public) - ironrdp-graphics: 0.7.1 → 0.8.0 (ironrdp-pdu 0.8 is public) - ironrdp-input: 0.5.1 → 0.6.0 (ironrdp-pdu 0.8 is public) - ironrdp-cliprdr: 0.5.1 → 0.6.0 (ironrdp-pdu 0.8, ironrdp-svc 0.7 are public) - ironrdp-dvc: 0.5.1 → 0.6.0 (ironrdp-pdu 0.8, ironrdp-svc 0.7 are public) - ironrdp-displaycontrol: 0.5.1 → 0.6.0 (ironrdp-pdu 0.8, ironrdp-svc 0.7 are public) - ironrdp-echo: 0.1.1 → 0.2.0 (ironrdp-pdu 0.8, ironrdp-dvc 0.6 are public) - ironrdp-rdpdr: 0.5.1 → 0.6.0 (ironrdp-pdu 0.8, ironrdp-error 0.2, ironrdp-svc 0.7 are public) - ironrdp-rdpsnd: 0.7.1 → 0.8.0 (ironrdp-pdu 0.8, ironrdp-svc 0.7 are public) - ironrdp-ainput: 0.5.1 → 0.6.0 (ironrdp-dvc 0.6 is public) - ironrdp-acceptor: 0.8.1 → 0.9.0 (ironrdp-pdu 0.8, ironrdp-connector 0.9, ironrdp-async 0.9 are public) - ironrdp-cliprdr-native: 0.5.1 → 0.6.0 (ironrdp-cliprdr 0.6 is public) - ironrdp-rdpdr-native: 0.5.1 → 0.6.0 (ironrdp-pdu 0.8, ironrdp-svc 0.7, ironrdp-rdpdr 0.6 are public) - ironrdp-rdpsnd-native: 0.5.1 → 0.6.0 (ironrdp-rdpsnd 0.8 is public) - ironrdp-dvc-pipe-proxy: 0.3.1 → 0.4.0 (ironrdp-pdu 0.8, ironrdp-svc 0.7 are public) - ironrdp-server: 0.10.1 → 0.11.0 (multiple breaking public deps) - ironrdp-futures: 0.6.1 → 0.7.0 (ironrdp-async 0.9 is public) - ironrdp-tokio: 0.8.1 → 0.9.0 (ironrdp-async 0.9 is public) - ironrdp: 0.14.1 → 0.15.0 (multiple breaking public deps) All downstream Cargo.toml version requirements and Cargo.lock updated. CHANGELOG files updated with [**breaking**] entries under Build section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
- ironrdp-pdu: remove 'Complete pixel format support' entry (commit did not touch ironrdp-pdu; only touched ironrdp-graphics and ironrdp-session) - ironrdp-pdu: rewrite 'Handle slow-path graphics' to describe the actual PDU-level change (added SlowPathGraphicsUpdate types) - ironrdp-graphics: rewrite 'Complete pixel format' entry to describe the actual change (added rdp_15bit_to_rgb color conversion) - ironrdp-error: mark 'Make fields of Error private' as [**breaking**] (making previously-public struct fields private is a breaking change) dep update entry (was omitted from the first commit) - ironrdp-connector: remove spurious 'Add arbitrary feature' entry (add + remove in same release window cancels out per deduplication rule) (the breaking dep entry and the Bump dep entry now appear under a single Build section instead of two separate ones) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Author
The Two fixup commits pushed ( Version bumps corrected (19 crates — patch → minor, public-dep propagation rule):
Changelog fixes: removed cross-crate misattributed entries, added missing All downstream Cargo.toml requirements and Cargo.lock were updated; |
Copilot
AI
changed the title
chore: attempt release-prep skill invocation for release PR
chore(release): apply release-prep skill pass — fix version bumps and changelogs
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executed the
release-prepskill procedure manually (the skill file exists at.github/skills/release-prep/SKILL.mdbut is not yet registered in the agent environment's skill registry).Changes Made
Version bump corrections (public-dependency propagation rule)
19 crates were incorrectly proposed as patch bumps by release-plz despite having breaking changes propagated through
# publicannotated dependencies. All corrected to minor bumps with cascading updates to consumerCargo.tomlversion requirements andCargo.lock:ironrdp-svcironrdp-pdu 0.8is publicironrdp-graphicsironrdp-pdu 0.8is publicironrdp-inputironrdp-pdu 0.8is publicironrdp-cliprdrironrdp-pdu 0.8,ironrdp-svc 0.7are publicironrdp-dvcironrdp-pdu 0.8,ironrdp-svc 0.7are publicironrdp-displaycontrolironrdp-pdu 0.8,ironrdp-svc 0.7are publicironrdp-echoironrdp-pdu 0.8,ironrdp-dvc 0.6are publicironrdp-rdpdrironrdp-pdu 0.8,ironrdp-error 0.2,ironrdp-svc 0.7are publicironrdp-rdpsndironrdp-pdu 0.8,ironrdp-svc 0.7are publicironrdp-ainputironrdp-dvc 0.6is publicironrdp-acceptorironrdp-pdu 0.8,ironrdp-connector 0.9,ironrdp-async 0.9are publicironrdp-cliprdr-nativeironrdp-cliprdr 0.6is publicironrdp-rdpdr-nativeironrdp-pdu 0.8,ironrdp-svc 0.7,ironrdp-rdpdr 0.6are publicironrdp-rdpsnd-nativeironrdp-rdpsnd 0.8is publicironrdp-dvc-pipe-proxyironrdp-pdu 0.8,ironrdp-svc 0.7are publicironrdp-serverironrdp-futuresironrdp-async 0.9is publicironrdp-tokioironrdp-async 0.9is publicironrdp[**breaking**]Build-section entries were added to all 19 affectedCHANGELOG.mdfiles.Changelog content fixes
ironrdp-pdu: Removed cross-crate "Complete pixel format support" entry (commit only touchedironrdp-graphics/ironrdp-session); rewrote "Handle slow-path graphics" to describe the PDU-level types actually addedironrdp-graphics: Rewrote "Complete pixel format" entry to describe the actualrdp_15bit_to_rgbcolor conversion changeironrdp-error: Marked "Make fields of Error private" as[**breaking**](making public struct fields private is a breaking change)ironrdp-cliprdr: Added missing[**breaking**]Build sectionironrdp-connector: Removed spurious "Add arbitrary feature" entry (feature was added and removed in the same release window — deduplication rule)<!-- 7 -->Buildsections in 9 changelogsVerification
cargo check --workspacepasses cleanly