refactor(web-client): improve Extension API#761
Closed
Alex Yusiuk (RRRadicalEdward) wants to merge 1 commit into
Closed
refactor(web-client): improve Extension API#761Alex Yusiuk (RRRadicalEdward) wants to merge 1 commit into
Extension API#761Alex Yusiuk (RRRadicalEdward) wants to merge 1 commit into
Conversation
| # WASM | ||
| wasm-bindgen = "0.2" | ||
| wasm-bindgen-futures = "0.4" | ||
| wasm-bindgen-derive = "0.3" |
Collaborator
Author
There was a problem hiding this comment.
I have tried to use wasm-bindgen convert module to be able to downcast from JsValue to an extension, but I have found that this module is unstable and gives different results each call (first call - fine, everything else - errors). This is a known issue: wasm-bindgen/wasm-bindgen#2231.
This crate fixes the issue.
|
|
||
| impl Extension { | ||
| pub(crate) fn try_from_js_value(value: JsValue) -> Result<Self, anyhow::Error> { | ||
| if let Ok(Some(display_control)) = try_from_js_option::<DisplayControl>(value.clone()) { |
Collaborator
Author
There was a problem hiding this comment.
We have to clone every time since wasm_bindgen_derive doesn't have an API to take JsValue by reference
Member
There was a problem hiding this comment.
This is looking much more complex than necessary to me. Here is what I had in mind: #762
Can you check this PR instead?
Collaborator
Author
|
Done in #762 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved the API based on the feedback in #749