refactor(web): iron_init/setup logic#763
Merged
Benoît Cortier (CBenoit) merged 1 commit intoApr 21, 2025
Merged
Conversation
- `iron_init` is renamed to `setup`, so that
- `init` is the function for initializing the WASM module.
- `setup` is the function taking parameters for logger and performing
other setting up operations.
- Since `setup` may be called after `init` is called, it’s possible to
use some functions of the WASM module before calling `setup` if
necessity arises.
- Common initializion code is moved to an hidden "internal" module of
iron-remote-desktop crate, that is thus not part of the public API.
- Restored the "IronRDP is ready" debug log when `setup` is called.
Alex Yusiuk (RRRadicalEdward)
approved these changes
Apr 21, 2025
Collaborator
Alex Yusiuk (RRRadicalEdward)
left a comment
Alex Yusiuk (RRRadicalEdward)
left a comment
There was a problem hiding this comment.
Clean 🧹
Benoît Cortier (CBenoit)
deleted the
refactor/iron-remote-desktop-setup-function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iron_initis renamed tosetup, so thatinitis the function for initializing the WASM module.setupis the function taking parameters for logger and performing other setting up operations.setupmay be called afterinitis called, it’s possible to use some functions of the WASM module before callingsetupif necessity arises.Common initializion code is moved to an hidden "internal" module of iron-remote-desktop crate, that is thus not part of the public API.
Restored the "IronRDP is ready" debug log when
setupis called.