Skip to content

Fix some warnings#2527

Merged
Martí Climent (marticliment) merged 9 commits intoDevolutions:mainfrom
Saibamen:fix_warnings
Jul 21, 2024
Merged

Fix some warnings#2527
Martí Climent (marticliment) merged 9 commits intoDevolutions:mainfrom
Saibamen:fix_warnings

Conversation

@Saibamen
Copy link
Copy Markdown
Contributor

No description provided.

@marticliment
Copy link
Copy Markdown
Collaborator

This PR had broken code. I would ask you to please use the https://github.com/marticliment/UniGetUI/blob/main/.github/PULL_REQUEST_TEMPLATE.md Pull Request Template, which enforces some steps before publishing a PR

Comment thread src/.editorconfig
@marticliment Martí Climent (marticliment) merged commit 33ade2e into Devolutions:main Jul 21, 2024
@Saibamen Adam Stachowicz (Saibamen) deleted the fix_warnings branch July 21, 2024 10:14
@Saibamen
Copy link
Copy Markdown
Contributor Author

Sorry, I had build problems on my Visual Studio, ARM64 was not found during compilation.

Probably after your commit with UniGetUI.PackageEngine.Managers.PowerShell7.csproj, but I'm not sure.

And after installing this package via Visual Studio Installer, I still had this error:
image

But everything was OK for GitHub Actions in this PR

@marticliment
Copy link
Copy Markdown
Collaborator

Oh, don't worry then. I faced this issue also, there was a corruption in the solution configuration. The issue should now be fixed

@Saibamen
Copy link
Copy Markdown
Contributor Author

Current master branch is building for me without any issues, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants