Skip to content

Ensure bundle file is saved with file extension (fix #2618)#2625

Merged
Martí Climent (marticliment) merged 12 commits intoDevolutions:mainfrom
gnerkus:bug-2618
Aug 28, 2024
Merged

Ensure bundle file is saved with file extension (fix #2618)#2625
Martí Climent (marticliment) merged 12 commits intoDevolutions:mainfrom
gnerkus:bug-2618

Conversation

@gnerkus
Copy link
Copy Markdown
Contributor

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.

  • fetch the user's file type selection
  • if no list of file types, default to .json

Closes #2618

@marticliment
Copy link
Copy Markdown
Collaborator

Looks good for me, I will test it out later this month and merge it

@marticliment
Copy link
Copy Markdown
Collaborator

Don't worry about merging main into your branch, I will do this when testing the PR

@gnerkus
Copy link
Copy Markdown
Contributor Author

Don't worry about merging main into your branch, I will do this when testing the PR

Got it.

@marticliment Martí Climent (marticliment) merged commit c8f1f9b into Devolutions:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Bundles can be saved without file extension

2 participants