Skip to content

Create .deepsource.toml, .whitesource, and Update WebBasedData/test_urls.py#2653

Merged
Martí Climent (marticliment) merged 12 commits intoDevolutions:mainfrom
skanda890:main
Aug 28, 2024
Merged

Create .deepsource.toml, .whitesource, and Update WebBasedData/test_urls.py#2653
Martí Climent (marticliment) merged 12 commits intoDevolutions:mainfrom
skanda890:main

Conversation

@skanda890
Copy link
Copy Markdown
Contributor

@skanda890 SkandaBT (skanda890) commented Aug 22, 2024 •
edited
Loading

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.

Create .deepsource.toml and .whitesource to check for security issues and more.

SkandaBT (skanda890) and others added 4 commits August 22, 2024 16:23
@skanda890
Update bug-issue.yml (#37)
2321ca8
@deepsource-io
ci: add .deepsource.toml
98c9793
@deepsource-autofix
style: format code with Autopep8, Black, dotnet-format, isort, Ruff F…
5ec4ab8 
…ormatter and Yapf (#38)

This commit fixes the style issues introduced in 98c9793 according to the output
from Autopep8, Black, dotnet-format, isort, Ruff Formatter and Yapf.

Details: None

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@skanda890
Merge branch 'marticliment:main' into main
43cf67e
@skanda890
Copy link
Copy Markdown
Contributor Author

SkandaBT (skanda890) commented Aug 22, 2024

Martí Climent (@marticliment), please review this and give some suggestions.

@marticliment
Copy link
Copy Markdown
Collaborator

Martí Climent (marticliment) commented Aug 22, 2024

please do not autoformat code

@skanda890 SkandaBT (skanda890) marked this pull request as draft August 22, 2024 12:53
@skanda890 SkandaBT (skanda890) changed the title Create .deepsource.toml and more Create .deepsource.toml Aug 22, 2024
@skanda890 SkandaBT (skanda890) marked this pull request as ready for review August 22, 2024 13:46
SkandaBT (skanda890) and others added 2 commits August 22, 2024 19:25
@skanda890
Update .deepsource.toml
c49345b
@mend-bolt-for-github
Add .whitesource configuration file (#41)
0c936fa 
Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com>
@skanda890 SkandaBT (skanda890) changed the title Create .deepsource.toml Create .deepsource.toml and .whitsource Aug 22, 2024
@skanda890 SkandaBT (skanda890) changed the title Create .deepsource.toml and .whitsource Create .deepsource.toml and .whitesource Aug 22, 2024
@skanda890
Copy link
Copy Markdown
Contributor Author

SkandaBT (skanda890) commented Aug 23, 2024 •
edited
Loading

Martí Climent (@marticliment), any more suggestions?

@deepsource-autofix
refactor: replace multiple == checks with in (#43)
aea5b3a 
To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained `in` it instead of checking for equality against each of the values.
This is faster, less verbose, and more readable.

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@skanda890 SkandaBT (skanda890) changed the title Create .deepsource.toml and .whitesource Create .deepsource.toml, .whitesource, and Update WebBasedData/test_urls.py Aug 23, 2024
@marticliment
Copy link
Copy Markdown
Collaborator

Martí Climent (marticliment) commented Aug 24, 2024

Why the refractoring?

@marticliment
Copy link
Copy Markdown
Collaborator

Martí Climent (marticliment) commented Aug 24, 2024

What do this files ( .deepsource.toml, .whitesource) do?

@skanda890
Copy link
Copy Markdown
Contributor Author

SkandaBT (skanda890) commented Aug 26, 2024

Why the refractoring?

To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained in it instead of checking for equality against each of the values. This is faster, less verbose, and more readable.

@skanda890
Copy link
Copy Markdown
Contributor Author

SkandaBT (skanda890) commented Aug 26, 2024

What do this files ( .deepsource.toml, .whitesource) do?

These files configure security bots like MendBolt and DeepSource.

@skanda890
Copy link
Copy Markdown
Contributor Author

SkandaBT (skanda890) commented Aug 26, 2024

Martí Climent (@marticliment), please accept or deny this as soon as possible as I am deleting all my forked repositories.

@marticliment
Copy link
Copy Markdown
Collaborator

Martí Climent (marticliment) commented Aug 26, 2024

Give me one week

@github-actions @excel-bot
Update icons and screenshots from the excel file (#44)
38b0bf8 
Co-authored-by: Excel Bot <excel-bot@users.noreply.github.com>
@marticliment Martí Climent (marticliment) merged commit 2bc5948 into Devolutions:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marticliment Martí Climent (marticliment) marticliment approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skanda890 @marticliment